Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] simple RECO squence for SPLASH runs #37624

Merged
merged 5 commits into from
May 10, 2022
Merged

Conversation

pmandrik
Copy link
Contributor

PR description:

For the beam SPLASH runs simplification of RECO sequence is proposed in order to speed up event processing in Event Display DQM clients. As simplified sequence is needed only for SPLASH runs, not for regular 'cosmic' and 'beam operation', the customization in visualizationProcessing function is applied when beamSplashRun option is True.

PR validation:

Tested locally, backport is to be tested at P5 in production using on-going runs.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37624/29393

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pmandrik for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)
  • DQM/Integration (dqm)

@perrotta, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@batinkov, @battibass, @Martin-Grunewald, @missirol, @threus, @fabiocos, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37624/29396

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #37624 was updated. @perrotta, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please check and sign again.

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42ff51/24037/summary.html
COMMIT: bcda02b
CMSSW: CMSSW_12_4_X_2022-04-19-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37624/24037/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-l1tstage2_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3589937
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3589913
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37624/29838

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

Pull request #37624 was updated. @perrotta, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented May 9, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42ff51/24548/summary.html
COMMIT: 7a55b8e
CMSSW: CMSSW_12_4_X_2022-05-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37624/24548/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3696633
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3696597
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@perrotta
Copy link
Contributor

+1

  • Sequence for splashes made available for possible future such runs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@davidlange6
Copy link
Contributor

davidlange6 commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants