-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2-gex131 Try to factorize a ddalgorithm used for forward pixel which can help in adopting legacy scenario to dd4hep #37645
Conversation
…in adopting legacy scenario to dd4hep
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37645/29442
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37645/29443
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e0667/24099/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@bsunanda , let us discuss this PR today. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37645/29482
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@cmsbuild Please Test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37645/29483
|
Pull request #37645 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e0667/24176/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda @civanch maybe I know a different definition of "factorize", but at a first glance I would say that if you add 1781 lines of code and remove only 11 you are not "factorizing" out anything. You are talking about a discussion: do you have a link to some slide or minutes of that discussion, so that we can have an idea of what are you actually doing here? Or maybe, could you just add a few more informative lines to the PR description? Moreover, mostly out of curiosity: why are you moving your debug messages from LogDebug to LogVerbatim? |
@perrrotta I take out only one activity of the earlier code which need to be done prior to analyze pixelfwdnipple.xml so that it can be adopted to dd4hep. The original code of DDPixfwdBlades could not be adopted for dd4hep because of this. Factorization may be a wrong word. I have not looked into compacticiation of the code at that time. The use of LogVerbatim helps me to get an easy access to log file without recompiling the code. I tried to explain this in the description. Please le me know a suitable title and I shall change that too. |
In the SIM meeting all the discussion happened orally - I ddi not prepare slides for that. The slides were for 2017, 2018 scenarios. Even the final conclusions for those were not in the original slides. Let me modify the slides to introduce them. |
+1 |
PR description:
Try to modify a ddalgorithm used for forward pixel which can help in adopting legacy scenario to dd4hep. Creation of a few rotation matrices was necessary in a separate step so that dd4hep workflow can work and this was the limitation why DDPixfwdBlade was not modified for dd4hep application. This change followed by the adoptation of this code for dd4hep will allow run1 and some of the run2 scenarios to be defined for dd4hep.
PR validation:
Tested by dumping the old and new scenario of forward pixel
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special