-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New set of files coherent with the new v1_0_0 L1Menu #37453
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37453/29148
|
A new Pull Request was created by @elfontan (Elisa Fontanesi) for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b038a2/23700/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@elfontan , do I understand correctly that the plan is to backport this PR (and the cms-data one) in time for |
Yes @missirol that's correct! |
Thanks, Elisa.
Besides standard wfs, I understand that having these updates (incl. cms-data/L1Trigger-L1TGlobal#9) would also be useful for groups measuring rates with the latest L1T menu (cc: @sanuvarghese @silviodonato). My suggestion is to mark this as urgent, open the backport to 12_3_X of this PR, and ask in cms-data/L1Trigger-L1TGlobal#9 to backport that cms-data tag update to 12_3_X. |
Thanks Marino, indeed, even though they are not strictly necessary, it would be useful to have it in the release. |
+1 |
PR description:
A full set of xml files for the L1 emulation of prescales and masks coherent with the updated L1 menu for Run 3 has been created and pushed to L1Trigger-L1TGlobal (PR#9). Once that these new files will be available in cms-data, we will proceed with the coherent update of these files. The update is targeting CMSSW_12_3_0.
The current version of the updated L1 Menu is L1Menu_Collisions2022_v1_0_0.
(Previous reference PR #37138)
In the context of the trigger studies for the preparation of the Run 3 menu (L1+HLT), we recently faced an issue related to the emulation of the L1 prescales. Two different issues were found out:
PR validation:
Basic tests performed successfully starting from CMSSW_12_4_X_2022-04-03-2300.
From CMSSW_12_4_X_2022-04-03-2300/src: