Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] New set of files coherent with the new v1_0_0 L1Menu #37497

Merged

Conversation

elfontan
Copy link
Contributor

@elfontan elfontan commented Apr 7, 2022

PR description:

Backport of #37453 to CMSSW_12_3_0.

A full set of xml files for the L1 emulation of prescales and masks coherent with the updated L1 menu for Run 3 has been created and pushed to L1Trigger-L1TGlobal (PR#9). A backport of these files has been requested in the github issue cms-data/L1Trigger-L1TGlobal#10. Changes will be backported to CMSSW_12_3_0 in cms-sw/cmsdist#7770 after the tests.

PR validation:

Basic tests performed successfully starting from CMSSW_12_3_X_2022-04-07-1100.

cmsrel CMSSW_12_3_X_2022-04-07-1100
cd CMSSW_12_3_X_2022-04-07-1100/src
cmsenv
git cms-addpkg L1Trigger/Configuration
git cms-addpkg L1Trigger/L1TGlobal
git cherry-pick 3626309
scram b distclean
git cms-checkdeps -a -A
scram b -j 8
scram b runtests
scram build code-checks
scram build code-format

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

A new Pull Request was created by @elfontan (Elisa Fontanesi) for CMSSW_12_3_X.

It involves the following packages:

  • L1Trigger/Configuration (l1)
  • L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@elfontan elfontan changed the title New set of files coherent with the new v1_0_0 L1Menu [Backport] New set of files coherent with the new v1_0_0 L1Menu Apr 7, 2022
@missirol
Copy link
Contributor

missirol commented Apr 7, 2022

backport of #37453

@missirol
Copy link
Contributor

missirol commented Apr 7, 2022

urgent

Targets 12_3_0.

@missirol
Copy link
Contributor

missirol commented Apr 7, 2022

please test

This PR does not need to be tested with any cms-data PR, as the files mentioned in this PR aren't actually used in any central wf.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05c371/23739/summary.html
COMMIT: b9c16b8
CMSSW: CMSSW_12_3_X_2022-04-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37497/23739/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697381
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697357
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@epalencia
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 8, 2022

Corresponding changes in cmsdist are backported in cms-sw/cmsdist#7770

@perrotta
Copy link
Contributor

perrotta commented Apr 8, 2022

@cmsbuild cmsbuild merged commit f4be4cd into cms-sw:CMSSW_12_3_X Apr 8, 2022
@elfontan elfontan deleted the EF_backport_newFilesRun3menu branch January 19, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants