-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop legacy MC generators #7763
Conversation
A new Pull Request was created by @iarspider for branch IB/CMSSW_12_4_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
please test |
Pull request #7763 was updated. |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f7900/23714/summary.html External BuildI found compilation warning when building: See details on the summary page. |
Pull request #7763 was updated. |
Pull request #7763 was updated. |
please test |
(hydjet++ still requires pythia6 and pyquen) |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f7900/23749/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
I had only doubts about cascade, so I asked the responsible person. It is OK to remove it. |
@Saptaparna @mkirsano @SiewYan thanks. Is hydjet++ used, or can it also be dropped? It will allow dropping pythia6 and pyquen. |
We shouldn't remove hydjet++ (and so P6). This is e.g. needed by HIN group. |
@agrohsje noted. |
The following PRs for main cmssw repository remove usage of legacy generators:
|
Hi @iarspider , Was the removal of Hydjet 1.9 discussed in a meeting? |
Hi @stahlleiton, no, it was not discussed. Sure, we can keep hydjet 1.9. |
Pull request #7763 was updated. |
Splitting into separate PRs as suggested by Shahzad. |
dear @stahlleiton. can you comment on what is missing to have hydjet++ for run 3? not pushing to remove 1.9, i am just trying to understand where we are. i assumed that this is ready as priority was very high (and we are discussing already since a bit). |
We are currently producing samples with Hydjet++ and will start a full study comparing Hydjet vs Hydjet++ within the HIN group. |
Thanks. Maybe nice to summarize at some point in a GEN meeting? I know it is very special but could still be interesting to see. @cms-sw/generators-l2, what do you think? |
Sure, we can present the results in a GEN meeting once the study is done. |
@cms-sw/generators-l2 We would like to drop the following MC generators:
pythia6hydjet 1.9.1These are ancient and not developed anymore