-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-select high purity tracks as input for muon reco in pp_on_AA era #36693
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36693/27761
|
A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: RelVals RelVals-INPUT AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals
RelVals-INPUT
Expand to see more relval errors ...
AddOn Tests
Expand to see more addon errors ... |
@Dr15Jones Apologies, a line got dropped copying to the IB. _selectHighPurity is set now, but that doesn't fix the issue in all these other instances of MuonIdProducer. |
If you add a You could also not read the |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36693/27770
|
Pull request #36693 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36693/27771
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36693/27942
|
Pull request #36693 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9277ce/21975/summary.html Comparison SummarySummary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR selects out highPurity tracks as input to the muon reconstruction for heavy ions. It was noticed that the efficiency of global muons dropped in central (high multiplicity) events. This inefficiency is larger than that observed for tracker tracks, which is modest, or for stand-alone muons, which are basically unaffected by centrality. We surmised that poor quality tracks must be interfering with the matching. It was found that by switching to highPurity tracks, we increased the efficiency of muon reconstruction at low momentum, without any effect at high momentum.
The highPurity requirement is dropped when the primary vertex is not found. This occurs in very low multiplicity events, particularly ultra-peripheral collisions. Primary vertex information is used in the track quality assignment, which leads to tracks often failing to be assigned as highPurity. The fake track contribution is such collisions is negligible, however, so this requirement can simply be dropped, reverting to the default behavior used for pp reconstruction.
This development was presented to the muon POG:
https://indico.cern.ch/event/1094481/#10-low-pt-reco-muon-efficiency
https://indico.cern.ch/event/1100342/contributions/4629173/attachments/2356132/4020819/muonRecoRun3_30112021.pdf
@flodamas
PR validation:
Tested with wfs 158 and 159