pre-select high purity tracks as input for muon reco in pp_on_AA era #36693

mandrenguyen · 2022-01-12T10:40:03Z

PR description:

This PR selects out highPurity tracks as input to the muon reconstruction for heavy ions. It was noticed that the efficiency of global muons dropped in central (high multiplicity) events. This inefficiency is larger than that observed for tracker tracks, which is modest, or for stand-alone muons, which are basically unaffected by centrality. We surmised that poor quality tracks must be interfering with the matching. It was found that by switching to highPurity tracks, we increased the efficiency of muon reconstruction at low momentum, without any effect at high momentum.

The highPurity requirement is dropped when the primary vertex is not found. This occurs in very low multiplicity events, particularly ultra-peripheral collisions. Primary vertex information is used in the track quality assignment, which leads to tracks often failing to be assigned as highPurity. The fake track contribution is such collisions is negligible, however, so this requirement can simply be dropped, reverting to the default behavior used for pp reconstruction.

This development was presented to the muon POG:
https://indico.cern.ch/event/1094481/#10-low-pt-reco-muon-efficiency
https://indico.cern.ch/event/1100342/contributions/4629173/attachments/2356132/4020819/muonRecoRun3_30112021.pdf

@flodamas

PR validation:

Tested with wfs 158 and 159

cmsbuild · 2022-01-12T10:47:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36693/27761

This PR adds an extra 36KB to repository

cmsbuild · 2022-01-12T10:48:07Z

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

RecoMuon/GlobalMuonProducer (reconstruction)
RecoMuon/GlobalTrackFinder (reconstruction)
RecoMuon/MuonIdentification (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@HuguesBrun, @bellan, @abbiendi, @Fedespring, @calderona, @sscruz, @jhgoh, @CeliaFernandez, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jpata · 2022-01-12T14:51:07Z

@cmsbuild please test

cmsbuild · 2022-01-12T17:15:16Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9277ce/21679/summary.html
COMMIT: 131c83b
CMSSW: CMSSW_12_3_X_2022-01-11-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36693/21679/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9277ce/21679/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9277ce/21679/git-merge-result

RelVals

11634.0

----- Begin Fatal Exception 12-Jan-2022 17:31:37 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MuonIdProducer label='hltMuonsReg'
Exception Message:
MissingParameter: Parameter 'pvInputTag' not found.
----- End Fatal Exception -------------------------------------------------

11634.7

----- Begin Fatal Exception 12-Jan-2022 17:31:52 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MuonIdProducer label='hltIterL3MuonsNoVtx'
Exception Message:
MissingParameter: Parameter 'pvInputTag' not found.
----- End Fatal Exception -------------------------------------------------

11634.911

----- Begin Fatal Exception 12-Jan-2022 17:32:13 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MuonIdProducer label='hltMuonsReg'
Exception Message:
MissingParameter: Parameter 'pvInputTag' not found.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

139.004139.004_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3/step2_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3.log
139.003139.003_RunHLTPhy2021+RunHLTPhy2021+HLTDR3_2021+RECODR3_HLTPhysics_Offline+HARVESTD2021HLTPhy/step2_RunHLTPhy2021+RunHLTPhy2021+HLTDR3_2021+RECODR3_HLTPhysics_Offline+HARVESTD2021HLTPhy.log
139.002139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB/step2_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 12-Jan-2022 17:14:45 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MuonIdProducer label='hltIterL3MuonsOpenMu'
Exception Message:
MissingParameter: Parameter 'pvInputTag' not found.
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 12-Jan-2022 17:16:29 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MuonIdProducer label='hltMuonsReg'
Exception Message:
MissingParameter: Parameter 'pvInputTag' not found.
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 12-Jan-2022 17:14:45 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MuonIdProducer label='hltIterL3MuonsOpenMu'
Exception Message:
MissingParameter: Parameter 'pvInputTag' not found.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

hlt_data_GRun

RecoMuon/MuonIdentification/plugins/MuonIdProducer.cc

mandrenguyen · 2022-01-12T18:59:12Z

@Dr15Jones Apologies, a line got dropped copying to the IB. _selectHighPurity is set now, but that doesn't fix the issue in all these other instances of MuonIdProducer.
pvInputTag is only needed when selectHighPurity is True. Probably a dumb question, but is there a way to make the code not bail when pvInputTag is not set (and not needed)?

Dr15Jones · 2022-01-12T19:02:44Z

If you add a fillDescriptions to MuonIdProducer you can set default values for even the tracked parameters.

You could also not read the pvInputTag parameter if selectHighPurity_ == false.

cmsbuild · 2022-01-12T19:02:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36693/27770

This PR adds an extra 24KB to repository

cmsbuild · 2022-01-12T19:03:08Z

Pull request #36693 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again.

cmsbuild · 2022-01-12T20:10:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36693/27771

This PR adds an extra 36KB to repository

cmsbuild · 2022-01-25T12:13:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36693/27942

This PR adds an extra 40KB to repository

cmsbuild · 2022-01-25T12:13:50Z

Pull request #36693 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again.

jpata · 2022-01-25T12:24:34Z

@cmsbuild please test

cmsbuild · 2022-01-25T16:12:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9277ce/21975/summary.html
COMMIT: eced23d
CMSSW: CMSSW_12_3_X_2022-01-24-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36693/21975/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 328 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3449324
DQMHistoTests: Total failures: 95
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3449207
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

jpata · 2022-01-26T13:01:44Z

+reconstruction

on top of pre-select high purity tracks as input for muon reco in pp_on_AA era #36693 (comment), fixes the rule 6.16 violation "All Modifier customizations on a module/Task/Sequence/Path should be applied on the same file that defines the module/Task/Sequence/Path." (thanks @perrotta for noticing)

cmsbuild · 2022-01-26T13:02:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-01-26T13:15:45Z

+1

cmsbuild added this to the CMSSW_12_3_X milestone Jan 12, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jan 12, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 12, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 12, 2022

cmsbuild added tests-rejected and removed tests-started labels Jan 12, 2022

Dr15Jones reviewed Jan 12, 2022

View reviewed changes

RecoMuon/MuonIdentification/plugins/MuonIdProducer.cc Show resolved Hide resolved

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Jan 12, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 12, 2022

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 12, 2022

cmsbuild added code-checks-pending pending-signatures reconstruction-pending tests-pending and removed fully-signed tests-rejected code-checks-approved labels Jan 25, 2022

code-format

eced23d

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 25, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 25, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 25, 2022

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Jan 26, 2022

cmsbuild added orp-approved and removed orp-pending labels Jan 26, 2022

cmsbuild merged commit 9e1d632 into cms-sw:master Jan 26, 2022

This was referenced Jan 26, 2022

Try a second time if pop fails in ReusableObjectHolder #36813

Closed

[Aarch64] Build with -march=armv8-a cms-sw/cmsdist#7593

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pre-select high purity tracks as input for muon reco in pp_on_AA era #36693

pre-select high purity tracks as input for muon reco in pp_on_AA era #36693

mandrenguyen commented Jan 12, 2022

cmsbuild commented Jan 12, 2022

cmsbuild commented Jan 12, 2022

jpata commented Jan 12, 2022

cmsbuild commented Jan 12, 2022

mandrenguyen commented Jan 12, 2022

Dr15Jones commented Jan 12, 2022

cmsbuild commented Jan 12, 2022

cmsbuild commented Jan 12, 2022

cmsbuild commented Jan 12, 2022

cmsbuild commented Jan 25, 2022

cmsbuild commented Jan 25, 2022

jpata commented Jan 25, 2022

cmsbuild commented Jan 25, 2022

jpata commented Jan 26, 2022

cmsbuild commented Jan 26, 2022

perrotta commented Jan 26, 2022

pre-select high purity tracks as input for muon reco in pp_on_AA era #36693

pre-select high purity tracks as input for muon reco in pp_on_AA era #36693

Conversation

mandrenguyen commented Jan 12, 2022

PR description:

PR validation:

cmsbuild commented Jan 12, 2022

cmsbuild commented Jan 12, 2022

jpata commented Jan 12, 2022

cmsbuild commented Jan 12, 2022

RelVals

RelVals-INPUT

AddOn Tests

mandrenguyen commented Jan 12, 2022

Dr15Jones commented Jan 12, 2022

cmsbuild commented Jan 12, 2022

cmsbuild commented Jan 12, 2022

cmsbuild commented Jan 12, 2022

cmsbuild commented Jan 25, 2022

cmsbuild commented Jan 25, 2022

jpata commented Jan 25, 2022

cmsbuild commented Jan 25, 2022

Comparison Summary

jpata commented Jan 26, 2022

cmsbuild commented Jan 26, 2022

perrotta commented Jan 26, 2022