-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventSetupInitTrait can now have state #36633
EventSetupInitTrait can now have state #36633
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36633/27637
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@jpata, @cmsbuild, @santocch, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
@makortel FYI |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec05ab/21541/summary.html Comparison SummarySummary:
|
- Constructor takes edm::ConsumesCollector - init method is no longer static - Also moved PhysicsTools/RecoAlgos modules to stream types
b801d80
to
0a03f01
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36633/27659
|
please test |
@clacaputo thanks for catching that. In this case, I thing it was good to remove that |
Related #36552 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec05ab/21552/summary.html Comparison SummarySummary:
|
+reconstruction
|
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This fixes all the CMS deprecated warnings in PhysicsTools/RecoAlgos.
PR validation:
git cms-checkdeps -a
on modified code to test compilation