Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventSetupInitTrait can now have state #36633

Merged
merged 1 commit into from
Jan 12, 2022
Merged

EventSetupInitTrait can now have state #36633

merged 1 commit into from
Jan 12, 2022

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Constructor takes edm::ConsumesCollector
  • init method is no longer static
  • Also moved PhysicsTools/RecoAlgos modules to stream types

This fixes all the CMS deprecated warnings in PhysicsTools/RecoAlgos.

PR validation:

  • did git cms-checkdeps -a on modified code to test compilation
  • all files using the modified code compile without the CMS deprecated warnings

@cmsbuild cmsbuild added this to the CMSSW_12_3_X milestone Jan 5, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36633/27637

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2022

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • CommonTools/CandAlgos (reconstruction)
  • CommonTools/RecoAlgos (reconstruction)
  • CommonTools/UtilAlgos (reconstruction)
  • PhysicsTools/RecoAlgos (analysis)

@jpata, @cmsbuild, @santocch, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @abbiendi, @mmarionncern, @jhgoh, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @hatakeyamak, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@clacaputo
Copy link
Contributor

@cmsbuild please test

@Dr15Jones
Copy link
Contributor Author

@makortel FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec05ab/21541/summary.html
COMMIT: b801d80
CMSSW: CMSSW_12_3_X_2022-01-05-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36633/21541/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3461659
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461626
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@makortel makortel mentioned this pull request Jan 5, 2022
Closed
2 tasks
@Dr15Jones
EventSetupInitTrait can now have state
0a03f01 
- Constructor takes edm::ConsumesCollector
- init method is no longer static
- Also moved PhysicsTools/RecoAlgos modules to stream types
@Dr15Jones Dr15Jones force-pushed the deprecated_PhysicsToolsRecoAlgos branch from b801d80 to 0a03f01 Compare January 6, 2022 14:45
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36633/27659

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2022

Pull request #36633 was updated. @jpata, @cmsbuild, @santocch, @clacaputo, @slava77 can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

@clacaputo thanks for catching that. In this case, I thing it was good to remove that using namespace declaration as it was not doing anything useful. I do, however, think our checker for using namespace in headers is overly agressive. We need to not have using namespace be at file level but it is perfectly fine to have inside the body of an inlined function.

@jpata
Copy link
Contributor

jpata commented Jan 6, 2022 •
edited
Loading

Related #36552

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec05ab/21552/summary.html
COMMIT: 0a03f01
CMSSW: CMSSW_12_3_X_2022-01-06-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36633/21552/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3461659
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3461625
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@clacaputo
Copy link
Contributor

+reconstruction

  • no differences in the test
  • technical, no reco changes

@qliphy
Copy link
Contributor

qliphy commented Jan 12, 2022

+1

@qliphy
Copy link
Contributor

qliphy commented Jan 12, 2022

merge

@cmsbuild cmsbuild merged commit b9eba88 into cms-sw:master Jan 12, 2022
This was referenced Jan 12, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Dr15Jones Dr15Jones deleted the deprecated_PhysicsToolsRecoAlgos branch January 18, 2022 19:15
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clacaputo clacaputo clacaputo left review comments

Assignees
No one assigned
Labels
analysis-approved code-checks-approved fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_3_X
Development

Successfully merging this pull request may close these issues.
6 participants
@Dr15Jones @cmsbuild @clacaputo @jpata @qliphy @santocch