-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-sim102 Make runtime variables to allow/disallow creation of SimHits for demonstration chambers #36652
Conversation
…nstration chambers
@cmsbuild Please test |
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d58ad3/21572/summary.html Comparison SummarySummary:
|
@bsunanda , what is the reason for lost of regression? |
@civanch I cannot think of the reason for this. With no change of the scenario, I cannot think why regression gives different results. Is it for Run3 or is it for Phase2 scenarios? |
@bsunanda , regression fail in Phase-2 WFs: 35034.0 | 717 |
@cmsbuild Please test |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36652/27729
|
Pull request #36652 was updated. @civanch, @mdhildreth can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d58ad3/21638/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Make runtime variables to allow/disallow creation of SimHits for demonstration chambers
PR validation:
Use the runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special