Run3-sim102 Make runtime variables to allow/disallow creation of SimHits for demonstration chambers

[bsunanda]

PR description:

Make runtime variables to allow/disallow creation of SimHits for demonstration chambers

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36652/27677

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4CMS/Muon/interface/MuonSensitiveDetector.h modified in PR(s): Run3 gex108 Modify all Run3 geometry scenarios by including demonstration chambers of GE21 & RPC, and detectors in forward region (BHM, PLT, BCMF) plus removing BSC #36585
  • File SimG4CMS/Muon/plugins/MuonSensitiveDetectorBuilder.cc modified in PR(s): Run3 gex108 Modify all Run3 geometry scenarios by including demonstration chambers of GE21 & RPC, and detectors in forward region (BHM, PLT, BCMF) plus removing BSC #36585
  • File SimG4CMS/Muon/src/MuonSensitiveDetector.cc modified in PR(s): Run3 gex108 Modify all Run3 geometry scenarios by including demonstration chambers of GE21 & RPC, and detectors in forward region (BHM, PLT, BCMF) plus removing BSC #36585
  • File SimG4Core/Application/python/g4SimHits_cfi.py modified in PR(s): Run3 gex108 Modify all Run3 geometry scenarios by including demonstration chambers of GE21 & RPC, and detectors in forward region (BHM, PLT, BCMF) plus removing BSC #36585

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• SimG4CMS/Muon (simulation)
• SimG4Core/Application (simulation)

@civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d58ad3/21572/summary.html
COMMIT: f79b6e2
CMSSW: CMSSW_12_3_X_2022-01-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36652/21572/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 977 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3461659
• DQMHistoTests: Total failures: 5538
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3456099
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[civanch]

@bsunanda , what is the reason for lost of regression?

[bsunanda]

@civanch I cannot think of the reason for this. With no change of the scenario, I cannot think why regression gives different results. Is it for Run3 or is it for Phase2 scenarios?

[civanch]

@bsunanda , regression fail in Phase-2 WFs:

35034.0 | 717
35234.999 | 1597
38634.0 | 3146

[bsunanda]

@cmsbuild Please test

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36652/27729

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #36652 was updated. @civanch, @mdhildreth can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d58ad3/21638/summary.html
COMMIT: fc190fd
CMSSW: CMSSW_12_3_X_2022-01-11-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36652/21638/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3461659
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3461620
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1