Backport of fixes on PPS geometry #35387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new position for pixel sensors
…ort, enlarged Envelop, and new position of pixel sensors
…d position w.r.t. bottom foil
|
A new Pull Request was created by @diemort (Gustavo Silveira) for CMSSW_12_0_X. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
I'll correct the rebase to avoid the unittest error. |
|
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test test2021Geometry had ERRORS Comparison SummarySummary:
|
|
Please exclude the file Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml
and Geometry/CMSCommonData/python/cmsExtendedGeometry2021_cfi.py from this PR. These are parts of the dictionary
…________________________________
From: cmsbuild ***@***.***
Sent: 23 September 2021 22:20
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Backport of fixes on PPS geometry (#35387)
-1
Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45357b/18868/summary.html
COMMIT: dfba27b<dfba27b>
CMSSW: CMSSW_12_0_X_2021-09-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35387/18868/install.sh to create a dev area with all the needed externals and cmssw changes.
Unit Tests
I found errors in the following unit tests:
---> test test2021Geometry had ERRORS
Comparison Summary
Summary:
* No significant changes to the logs found
* Reco comparison results: 0 differences found in the comparisons
* DQMHistoTests: Total files compared: 39
* DQMHistoTests: Total histograms compared: 2998564
* DQMHistoTests: Total failures: 0
* DQMHistoTests: Total nulls: 0
* DQMHistoTests: Total successes: 2998542
* DQMHistoTests: Total skipped: 22
* DQMHistoTests: Total Missing objects: 0
* DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
* Checked 165 log files, 37 edm output root files, 39 DQM output files
* TriggerResults<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_X_2021-09-23-1100+45357b/45692/triggerResults>: no differences found
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#35387 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOWJMBBGRTMIUWMJVULUDODZHANCNFSM5EUEIEHA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This is a backport of #35380 to CMSSW_12_0_1.
This PR addresses a few minor corrections on the PPS geometry in the Pixel sensors and complies the material names in the reco geometry as stated in #34927. The position of the Silicon wafers has been move down to 250um w.r.t. the bottom foil and the envelopes with sensors ad flexible cables has been enlarged to avoid volume overlaps. Besides, the U shape of the Aluminum supports has been changed to a plain squared piece. A detailed list of the file changes and visualization of the new changes in the Pixel sensors is given in this twiki.
Includes updated on both DDD and dd4hep files and keeps the default dict2021Geometry.py for 12_0.
PR validation:
The new changes in the geometry have been validated with the full CMS geometry dump for visualization and overlap check with tolerance 0.01, plus direct and full simulation to confirm hits in both pixel and timing detectors. The position of the pixel sensors have been checked with direct simulation here.
if this PR is a backport please specify the original PR and why you need to backport that PR:
PR #35380, needed to update PPS geometry for Run3.
All changes follow the Naming Rules for new XML files in geometry.
All workflow tests done.
FYI @fabferro @jan-kaspar