-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for PPS geometry on Pixel sensors and materials #35380
Conversation
…new position for pixel sensors
…ort, enlarged Envelop, and new position of pixel sensors
…d position w.r.t. bottom foil
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35380/25470
|
A new Pull Request was created by @diemort (Gustavo Silveira) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4606d/18858/summary.html Comparison SummarySummary:
|
urgent |
+1 |
@AdrianoDee, @srimanob , we agreed today to push this PR needed for geometry scenario. |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR addresses a few minor corrections on the PPS geometry in the Pixel sensors and complies the material names in the reco geometry as stated in #34927. The position of the Silicon wafers has been move down to 250um w.r.t. the bottom foil and the envelopes with sensors ad flexible cables has been enlarged to avoid volume overlaps. Besides, the U shape of the Aluminum supports has been changed to a plain squared piece. A detailed list of the file changes and visualization of the new changes in the Pixel sensors is given in this twiki.
Includes updated on both DDD and dd4hep files as well as a new entry in dict2021Geometry.py named P7 with the latest geometry XML files.
PR validation:
The new changes in the geometry have been validated with the full CMS geometry dump for visualization and overlap check with tolerance 0.01, plus direct and full simulation to confirm hits in both pixel and timing detectors. The position of the pixel sensors have been checked with direct simulation here.
All changes follow the Naming Rules for new XML files in geometry.
All workflow tests done.
FYI @fabferro @jan-kaspar