Run3-gex89 Attempt to define unqiue names of materials everywhere

[bsunanda]

PR description:

Attempt to define unqiue names of materials everywhere. Remove duplicate names from materials.xml (which are defined in tracker.xml) and make sure that names of all materials for PPS to be preceded by PPS_

PR validation:

Use some of runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34927/24735

• This PR adds an extra 64KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Configuration/Geometry (geometry, upgrade)
• Geometry/CMSCommonData (geometry, upgrade)
• Geometry/VeryForwardData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks.
@vargasa, @fabferro, @jan-kaspar, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cvuosalo @civanch I have made changes and removed possibility of defining materials with the same name. Checked for materials defined for tracker, calorimeters and forward systems. The relevant cfi's are in Geometry/VeryForwardData/python (for DDD) and in Geometry/VeryForwardData/dd4hep (for DD4Hep). We can start testing now

[bsunanda]

@cmsbuild Please test

[cvuosalo]

@bsunanda Have you seen in any preliminary tests that the discrepancies are resolved by this change?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0fe37/17848/summary.html
COMMIT: 75859ae
CMSSW: CMSSW_12_1_X_2021-08-17-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34927/17848/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000330
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[srimanob]

@bsunanda @civanch @cvuosalo
Thanks very much.
If I pick up this PR on top of 12_1, is it enough to test with XML geometry used in SIM, RECO steps?

[civanch]

@bsunanda , there is typo in this file name ",xml"

[bsunanda]

@cmsbuild Please test

[cvuosalo]

hold

[cmsbuild]

Pull request has been put on hold by @cvuosalo
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cvuosalo]

Let's wait a little bit on this PR. It makes a big perturbation to the Geometry materials right at the same time we are checking the materials for other issues.

[cvuosalo]

unhold

[cvuosalo]

Let's go forward with this PR and get it merged soon.

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

This PR does not fix the issue but is useful in general.

Just for completeness of information: which is the issue that is mentioned several times in this thread, and which is "not fixed" by this PR? @bsunanda @civanch @cvuosalo

[bsunanda]

There was a discrepancy of material budget in the tracker between the xml and db version for the dd4hep implementation. This PR tries to avoid duplicate material names which could be a cause. It was later on established that the order in which materials are defined was causing this and this was taken care of in a separate PR. However avoiding duplicate names is a good practice and defining materials with the same name but of different properties is confusing and must be avoided.

[bsunanda]

@perrotta I tried to send a comment. It was discussed in the Simulation meetings (and chats) at great length

[bsunanda]

@qliphy @perrotta @cvuosalo @civanch Please include this in IB at the earliest. We need to define a new scenario to be used for the next GT

[perrotta]

+1

• Renamed materials whenever it was instrumental to cleanup the configurations in geometry
• (@bsunanda : we had to wait for a clean IB and able to compile with Run3-hcx310 Put back HcalDigiProducer.cc in SimCalorimetry/HcalSimProducers/src #34972 merged: that's why this PR was not merged during the week end. Following developments, e.g. [DD4hep] Revise order of materials to prevent delayed resolution of references #34974, can be tested and eventually integrated on top the forhcoming IBs which contain this one)