Do not process stack configs when executing command atmos vendor pull and the stack flag is not specified

[haitham911]

what

• Do not process stack configs when executing command atmos vendor pull and the stack flag is not specified

why

• Atmos vendor should not require stack configs if the stack flag is not provided

references

• DEV-2689
• https://linear.app/cloudposse/issue/DEV-2689/atmos-vendor-should-not-require-stack-configs

Summary by CodeRabbit

• New Features

  • Enhanced vendor pull command to dynamically handle stack configurations based on the stack flag.

• Bug Fixes

  • Preserved error handling and validation for command-line flags, ensuring consistent functionality.

• Chores

  • Updated various dependencies to their latest versions for improved compatibility and performance.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes in this pull request involve a modification to the ExecuteVendorPullCommand function within the internal/exec/vendor_utils.go file. The key alteration is the adjustment of the second argument in the cfg.InitCliConfig function based on the state of the "stack" flag, allowing for dynamic handling of stack configurations. The overall command logic, including flag handling and error processing, remains unchanged.

Changes

File	Change Summary
internal/exec/vendor_utils.go	Modified ExecuteVendorPullCommand to dynamically set the second argument of cfg.InitCliConfig(info, processStacks) based on the "stack" flag. Flag handling and error processing remain unchanged.
go.mod	Updated dependency versions: mvdan.cc/sh to v3.10.0, golang.org/x/mod to v0.18.0, golang.org/x/sys to v0.26.0, golang.org/x/term to v0.25.0, and golang.org/x/tools to v0.22.0.

Possibly related PRs

• Refactor logging in ExecuteAtmosVendorInternal function #730: The changes in this PR enhance logging in the ExecuteAtmosVendorInternal function, which is closely related to the ExecuteVendorPullCommand function modified in the main PR, as both functions are part of the same file and deal with vendor configuration processing.
• get atmos config and vendor from .yaml or .yml #736: This PR modifies the ExecuteVendorPullCommand function by enhancing the handling of vendor configuration files, which directly relates to the changes made in the main PR regarding the initialization of configuration based on the stack flag.

Suggested labels

minor, no-release

Suggested reviewers

• hans-d
• nitrocode

🐇 In the meadow, changes hop,
Vendor pulls, with flags that swap.
Logic stays, but flows anew,
A simpler path for all to view.
With each tweak, we leap and cheer,
For clearer code, we hold so dear! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 89a1754 and 5667f43.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (2)

• go.mod (2 hunks)
• internal/exec/vendor_utils.go (1 hunks)

🧰 Additional context used

🔇 Additional comments (7)

go.mod (6)

240-240: Approve update to stable version for golang.org/x/tools

The update from v0.21.1-0.20240508182429-e35e4ccd0d2d (a pre-release version) to v0.22.0 (a stable release) is a significant change. This update likely includes important improvements and new features.

Given the significance of this update, please run the following command to thoroughly check the changelog or release notes, and carefully review any breaking changes or new features:

#!/bin/bash
# Fetch the changelog for golang.org/x/tools and display changes for v0.22.0
gh repo view golang/tools --json url -q .url.html | xargs -I {} curl -sL {}/raw/master/CHANGES | sed -n '/^v0.22.0/,/^v0.21.0/p'

---

Line range hint 44-240: Summary of dependency updates

The go.mod file has been updated with several minor version changes to core Go modules and related dependencies. These updates are generally expected to be backwards compatible and include improvements and bug fixes. The most significant change is the update of golang.org/x/tools from a pre-release version to a stable release.

To ensure overall compatibility and understand the impact of these changes, please run the following commands:

#!/bin/bash
# Verify that the module builds successfully with the new dependencies
go mod tidy
go build ./...

# Run tests to ensure no regressions
go test ./...

# If applicable, run any integration or end-to-end tests
# [Add commands for running integration tests here]

After running these commands, carefully review the output for any errors or unexpected behavior. If any issues are found, please investigate and address them before merging this pull request.

---

232-232: Approve minor version update for golang.org/x/mod

The update from v0.17.0 to v0.18.0 is a minor version change for a core Go module. This update likely includes improvements and bug fixes.

To ensure compatibility and understand the changes, please run the following command to check the changelog or release notes:

#!/bin/bash
# Fetch the changelog for golang.org/x/mod and display changes between v0.17.0 and v0.18.0
gh repo view golang/mod --json url -q .url.html | xargs -I {} curl -sL {}/raw/master/CHANGES | sed -n '/^v0.18.0/,/^v0.17.0/p'

---

236-236: Approve minor version update for golang.org/x/sys

The update from v0.25.0 to v0.26.0 is a minor version change for a core Go module. This update likely includes platform-specific improvements and bug fixes.

To ensure compatibility and understand the changes, please run the following command to check the changelog or commit history:

✅ Verification successful

golang.org/x/sys has been successfully updated to v0.26.0

The go.mod and go.sum files confirm that golang.org/x/sys has been updated to version v0.26.0 without any replace directives.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Fetch the commit history for golang.org/x/sys and display changes between v0.25.0 and v0.26.0
gh repo view golang/sys --json url -q .url.html | xargs -I {} git -c 'versionsort.suffix=-' ls-remote --tags --sort=-v:refname {} 'v0.2*' | head -n 2 | awk '{print $2}' | cut -d/ -f3 | xargs -I {} curl -sL https://github.com/golang/sys/compare/{}

Length of output: 351

---

Script:

#!/bin/bash
# Verify the version update of golang.org/x/sys in go.mod
grep 'golang.org/x/sys' go.mod

Length of output: 68

---

Script:

#!/bin/bash
# Check for replace directives for golang.org/x/sys in go.mod
grep 'replace golang.org/x/sys' go.mod

# Verify the version of golang.org/x/sys in go.sum
grep 'golang.org/x/sys' go.sum

Length of output: 10012

---

44-44: Approve minor version update for mvdan.cc/sh/v3

The update from v3.9.0 to v3.10.0 is a minor version change, which should be backwards compatible. This update likely includes new features and bug fixes.

To ensure compatibility, please run the following command to check for any breaking changes or significant updates in the changelog:

---

237-237: Approve minor version update for golang.org/x/term

The update from v0.24.0 to v0.25.0 is a minor version change for a core Go module. This update likely includes improvements related to terminal handling and compatibility.

To ensure compatibility and understand the changes, please run the following command to check the changelog or commit history:

✅ Verification successful

Verify minor version update for golang.org/x/term

The update from v0.24.0 to v0.25.0 of golang.org/x/term involves a single change:

• The golang.org/x/sys dependency has been updated from v0.25.0 to v0.26.0.

This minor version update of a core dependency suggests that the term package is being maintained with up-to-date dependencies. The change is likely to be compatible with existing code and may include new features or non-breaking improvements in the sys package.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Fetch the commit history for golang.org/x/term and display changes between v0.24.0 and v0.25.0
gh repo view golang/term --json url -q .url.html | xargs -I {} git -c 'versionsort.suffix=-' ls-remote --tags --sort=-v:refname {} 'v0.2*' | head -n 2 | awk '{print $2}' | cut -d/ -f3 | xargs -I {} curl -sL https://github.com/golang/term/compare/{}

Length of output: 351

---

Script:

#!/bin/bash
# Fetch the comparison between v0.24.0 and v0.25.0 for golang.org/x/term
curl -sL https://github.com/golang/term/compare/v0.24.0...v0.25.0

Length of output: 198319

---

Script:

#!/bin/bash
# Clone the repository and examine changes between v0.24.0 and v0.25.0
git clone https://github.com/golang/term.git
cd term
git fetch --all --tags
echo "Commit log between v0.24.0 and v0.25.0:"
git log --oneline v0.24.0..v0.25.0
echo "\nFiles changed between v0.24.0 and v0.25.0:"
git diff --name-only v0.24.0 v0.25.0

Length of output: 493

---

Script:

#!/bin/bash
# Show the diff of go.mod file between v0.24.0 and v0.25.0
cd term
echo "Diff of go.mod between v0.24.0 and v0.25.0:"
git diff v0.24.0 v0.25.0 -- go.mod

Length of output: 350

internal/exec/vendor_utils.go (1)

30-35: LGTM! The changes successfully implement the PR objectives.

The introduction of the processStacks variable and its usage in cfg.InitCliConfig effectively stops the processing of stack configurations when running atmos vendor pull, unless the 'stack' flag is explicitly set. This change aligns perfectly with the PR objectives and addresses the issue mentioned in DEV-2689.

To ensure the changes are working as intended across the codebase, let's verify the usage of InitCliConfig:

This will help us confirm that the changes don't negatively impact other parts of the codebase that use InitCliConfig.

Also applies to: 38-38

✅ Verification successful

Verification Successful!

The processStacks variable introduced in internal/exec/vendor_utils.go is correctly implemented. Other usages of InitCliConfig across the codebase remain unaffected.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the usage of InitCliConfig across the codebase
rg "InitCliConfig\s*\([^)]*\)" -A 3

Length of output: 14003

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between a70d456 and 01f06fe.

📒 Files selected for processing (1)

• internal/exec/vendor_utils.go (1 hunks)

🧰 Additional context used

[aknysh]

thanks @haitham911

[github-actions]

These changes were released in v1.95.0.

[osterman]

This closes #392, as stack configs are no longer required.