Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not process stack configs when executing command atmos vendor pull and the stack flag is not specified #738

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Do not process stack configs when executing command atmos vendor pull and the stack flag is not specified #738

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a70d456
modify InitCliConfig in ExecuteVendorPullCommand
haitham911 Oct 21, 2024
01f06fe
check stack flag is set on vendor pull
haitham911 Oct 21, 2024
89a1754
Merge branch 'main' into DEV-2689
osterman Oct 21, 2024
5667f43
updates
aknysh Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/exec/vendor_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ func ExecuteVendorPullCommand(cmd *cobra.Command, args []string) error {
if err != nil {
return err
}

// check stack flag is set
processStacks := cmd.Flags().Changed("stack")
// InitCliConfig finds and merges CLI configurations in the following order:
// system dir, home dir, current dir, ENV vars, command-line arguments
cliConfig, err := cfg.InitCliConfig(info, true)
cliConfig, err := cfg.InitCliConfig(info, processStacks)
aknysh marked this conversation as resolved.
Show resolved Hide resolved
if err != nil {
return err
}
Expand Down