-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Roll bazel 7.3.1:7.4.1 #2981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fhanau
commented
Oct 22, 2024
•
edited
Loading
edited
- Enable BwoB on Windows again now that Parent directory of output file not made writable when building without the bytes bazelbuild/bazel#23462 has been fixed.
fhanau
force-pushed
the
felix/bazel-7.4.0
branch
4 times, most recently
from
October 23, 2024 14:30
525266f
to
2a18cfb
Compare
|
fhanau
added a commit
that referenced
this pull request
Oct 23, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for @down taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected.
fhanau
added a commit
that referenced
this pull request
Oct 23, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected.
fhanau
added a commit
that referenced
this pull request
Oct 26, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected.
fhanau
added a commit
that referenced
this pull request
Oct 26, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected.
fhanau
added a commit
that referenced
this pull request
Oct 26, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected.
fhanau
added a commit
that referenced
this pull request
Oct 26, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected.
fhanau
force-pushed
the
felix/bazel-7.4.0
branch
from
November 6, 2024 22:02
2a18cfb
to
26dcac1
Compare
- Enable BwoB on Windows again now that bazelbuild/bazel#23462 has been fixed.
fhanau
force-pushed
the
felix/bazel-7.4.0
branch
from
November 6, 2024 22:26
26dcac1
to
6473a60
Compare
fhanau
changed the title
[build] Roll bazel 7.3.1:7.4.0, emit bazel profile as artifact
[build] Roll bazel 7.3.1:7.4.1
Nov 6, 2024
|
mikea
approved these changes
Nov 7, 2024
jp4a50
approved these changes
Nov 7, 2024
fhanau
added a commit
that referenced
this pull request
Nov 7, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected. Fetching WPT also contributes here. Only fetch/use WPT on Unix and only configure targets based on globs as we start using them, Bazel configures 90,000 targets for it otherwise.
fhanau
added a commit
that referenced
this pull request
Nov 7, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected. Fetching WPT also contributes here. Only fetch/use WPT on Unix and only configure targets based on globs as we start using them, Bazel configures 90,000 targets for it otherwise.
fhanau
added a commit
that referenced
this pull request
Nov 8, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected. Fetching WPT also contributes here. Only fetch/use WPT on Unix and only configure targets based on globs as we start using them, Bazel configures 90,000 targets for it otherwise.
fhanau
added a commit
that referenced
this pull request
Nov 8, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected. Fetching WPT also contributes here. Only fetch/use WPT on Unix and only configure targets based on globs as we start using them, Bazel configures 90,000 targets for it otherwise.
fhanau
added a commit
that referenced
this pull request
Nov 8, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected. Fetching WPT also contributes here. Only fetch/use WPT on Unix and only configure targets based on globs as we start using them, Bazel configures 90,000 targets for it otherwise.
fhanau
added a commit
that referenced
this pull request
Nov 8, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI, especially on mostly cached builds. Based on profiling on #2981, this is caused by the repo mapping stage for dawn taking several minutes of Windows. Disable the experimental WebGPU feature on Windows to better meet compile time constraints. Release builds remain unaffected. Fetching WPT also contributes here. Only fetch/use WPT on Unix and only configure targets based on globs as we start using them, Bazel configures 90,000 targets for it otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.