Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Roll bazel 7.3.1:7.4.1 #2981

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[build] Roll bazel 7.3.1:7.4.1 #2981

merged 1 commit into from
Nov 7, 2024

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Oct 22, 2024

@fhanau fhanau force-pushed the felix/bazel-7.4.0 branch 4 times, most recently from 525266f to 2a18cfb Compare October 23, 2024 14:30
@fhanau
Copy link
Collaborator Author

fhanau commented Oct 23, 2024

This is stalled based on a change to how assembly is being compiled in Bazel 7.4.0 bazelbuild/bazel#23128 (comment) CC @mikea

fhanau added a commit that referenced this pull request Oct 23, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for @down
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
fhanau added a commit that referenced this pull request Oct 23, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
fhanau added a commit that referenced this pull request Oct 26, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
fhanau added a commit that referenced this pull request Oct 26, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
fhanau added a commit that referenced this pull request Oct 26, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
fhanau added a commit that referenced this pull request Oct 26, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
@fhanau fhanau force-pushed the felix/bazel-7.4.0 branch from 2a18cfb to 26dcac1 Compare November 6, 2024 22:02
- Enable BwoB on Windows again now that bazelbuild/bazel#23462
has been fixed.
@fhanau fhanau force-pushed the felix/bazel-7.4.0 branch from 26dcac1 to 6473a60 Compare November 6, 2024 22:26
@fhanau fhanau changed the title [build] Roll bazel 7.3.1:7.4.0, emit bazel profile as artifact [build] Roll bazel 7.3.1:7.4.1 Nov 6, 2024
@fhanau
Copy link
Collaborator Author

fhanau commented Nov 6, 2024

- [ ] Wait until 7.4.1 proper is released and use that before merging instead of a release candidate.
After internal discussion we will proceed with this to incorporate the cache bug fix and improve the Windows build situation.

@fhanau fhanau marked this pull request as ready for review November 6, 2024 22:58
@fhanau fhanau requested review from a team as code owners November 6, 2024 22:58
@fhanau fhanau requested review from jasnell and jp4a50 November 6, 2024 22:58
@fhanau fhanau merged commit 1301bb4 into main Nov 7, 2024
14 checks passed
@fhanau fhanau deleted the felix/bazel-7.4.0 branch November 7, 2024 17:13
fhanau added a commit that referenced this pull request Nov 7, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
Fetching WPT also contributes here. Only fetch/use WPT on Unix and only
configure targets based on globs as we start using them, Bazel configures
90,000 targets for it otherwise.
fhanau added a commit that referenced this pull request Nov 7, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
Fetching WPT also contributes here. Only fetch/use WPT on Unix and only
configure targets based on globs as we start using them, Bazel configures
90,000 targets for it otherwise.
fhanau added a commit that referenced this pull request Nov 8, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
Fetching WPT also contributes here. Only fetch/use WPT on Unix and only
configure targets based on globs as we start using them, Bazel configures
90,000 targets for it otherwise.
fhanau added a commit that referenced this pull request Nov 8, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
Fetching WPT also contributes here. Only fetch/use WPT on Unix and only
configure targets based on globs as we start using them, Bazel configures
90,000 targets for it otherwise.
fhanau added a commit that referenced this pull request Nov 8, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
Fetching WPT also contributes here. Only fetch/use WPT on Unix and only
configure targets based on globs as we start using them, Bazel configures
90,000 targets for it otherwise.
fhanau added a commit that referenced this pull request Nov 8, 2024
The Windows build is currently much slower than the macOS/Linux builds on CI,
especially on mostly cached builds.
Based on profiling on #2981, this is caused by the repo mapping stage for dawn
taking several minutes of Windows. Disable the experimental WebGPU feature on
Windows to better meet compile time constraints. Release builds remain
unaffected.
Fetching WPT also contributes here. Only fetch/use WPT on Unix and only
configure targets based on globs as we start using them, Bazel configures
90,000 targets for it otherwise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants