Skip to content

Commit

Permalink
[build] Roll bazel 7.3.1:7.4.1
Browse files Browse the repository at this point in the history
- Enable BwoB on Windows again now that bazelbuild/bazel#23462
has been fixed.
  • Loading branch information
fhanau committed Nov 6, 2024
1 parent 5f107eb commit 26dcac1
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 11 deletions.
7 changes: 2 additions & 5 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,11 @@ common --noenable_bzlmod

# bazel7 enables Build without the Bytes (BwoB) by default. This significantly speeds up builds
# using the remote cache since less data needs to be fetched. Set remote_cache_eviction_retries
# just in case there are cache evictions during the build.
build --experimental_remote_cache_eviction_retries=3
# which is required to fully support a "dumb" cache. Bazel 8 already sets this value by default.
build --experimental_remote_cache_eviction_retries=5
# Note that we use remote_download_minimal for test builds, which avoids fetching build outputs
# where possible. While several previous BwoB bugs have been fixed, this is slower than it could be
# due to https://github.com/bazelbuild/bazel/issues/20576.
# Windows build is failing on some runs due to FileAccessException errors, Bazel has had several
# similar bugs in the past. Disable BwoB for now.
build:windows --remote_download_all

# Import CI-specific configuration. As the amount of custom configuration settings we use grows,
# consider moving more flags out to separate files.
Expand Down
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7.3.1
7.4.1rc2
3 changes: 0 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@ jobs:
- os: { name: linux, image: ubuntu-20.04 }
config: { suffix: -asan }
# Windows has a custom non-debug bazel config.
# As of 7.2.1 support for Bazel remote cache BwoB is broken on Windows, likely due to
# disk I/O race conditions causing permission denied errors (this also happened in
# previous versions). Use remote_download_all for now.
- os: { name : windows, image : windows-2022 }
config: { suffix: '' }
# TODO (later): The custom Windows-debug configuration consistently runs out of disk
Expand Down
2 changes: 0 additions & 2 deletions build/ci.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,5 @@ build:ci-macOS --copt=-UDEBUG

build:ci-macOS-debug --config=debug

build:ci-windows-common --remote_download_all

build:ci-windows --config=windows_no_dbg --config=ci-windows-common
build:ci-windows-debug --config=debug --config=ci-windows-common

0 comments on commit 26dcac1

Please sign in to comment.