Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research possibility to use donut CSS rule to exclude pieces of DOM from our CSS reset #11451

Closed
Reinmar opened this issue Mar 10, 2022 · 4 comments · Fixed by #11461
Closed

Research possibility to use donut CSS rule to exclude pieces of DOM from our CSS reset #11451

Reinmar opened this issue Mar 10, 2022 · 4 comments · Fixed by #11461
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark package:ui squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 52 (v34...

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 10, 2022

The case is that someone may want to use their UI inside our UI. Their UI may expect no reset rules to be used.

How can they say that starting from some container our CSS reset rules should not apply?
@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". squad:core Issue to be handled by the Core team. labels Mar 10, 2022
@Reinmar Reinmar added domain:ui/ux This issue reports a problem related to UI or UX. package:ui labels Mar 10, 2022
@Reinmar
Copy link
Member Author

Reinmar commented Mar 10, 2022

The idea to verify is changing

.ck.ck-reset_all *

to:

.ck-reset_all *:not(.ck-reset_exclude *)

@Reinmar
Copy link
Member Author

Reinmar commented Mar 10, 2022

Does it work? Doesn't it change the rule's specificity (which would break some other styles that rely on the reset having specificity 020)? Does it really allow switching of the reset rules inside the .ck-reset_exclude container?

@Reinmar Reinmar added the support:2 An issue reported by a commercially licensed client. label Mar 10, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 14, 2022
@oleq oleq mentioned this issue Mar 14, 2022
Merged
@oleq
Copy link
Member

oleq commented Mar 14, 2022

@oleq oleq mentioned this issue Mar 14, 2022
Closed
@oleq
Copy link
Member

oleq commented Mar 14, 2022

If the PR is merged, there's an optional followup about taking advantage of this feature #11462.

@Reinmar Reinmar mentioned this issue Mar 28, 2022
Closed
Reinmar added a commit that referenced this issue Mar 28, 2022
@Reinmar
Merge pull request #11461 from ckeditor/ck/11451-css-reset-exclude
8e3b902 
Feature (theme-lark): Implemented a `.ck-reset_all-excluded` CSS class that excludes certain elements from CSS reset. Closes #11451.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 28, 2022
@CKEditorBot CKEditorBot added this to the iteration 52 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark package:ui squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 52 (v34.0.0)
Development

Successfully merging a pull request may close this issue.

Allowed excluding certain elements from CSS reset ckeditor/ckeditor5
3 participants
@Reinmar @oleq @CKEditorBot