Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of the possibility to exclude certain UI elements from CSS reset #11462

Closed
oleq opened this issue Mar 14, 2022 · 4 comments
Closed
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark resolution:expired This issue was closed due to lack of feedback. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oleq
Copy link
Member

oleq commented Mar 14, 2022

Provide a description of the task

#11451 brings a class that disables CSS reset on specific UI elements. There are some that could benefit from this to name a few:

@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". package:theme-lark domain:ui/ux This issue reports a problem related to UI or UX. labels Mar 14, 2022
@oleq
Copy link
Member Author

oleq commented Mar 28, 2022

Referring my comment from #11522:

This is not a silver bullet and does not replace web components in 100%. It's an improvement over what we had, though. Some styles will trickle down from parents because this is how inheritance works in CSS, there's no way to seal this up.

dawidurbanski added a commit that referenced this issue Mar 29, 2022
…ude-reset

Internal (style): Excluded the style preview from CSS UI reset making it easier to integrate the feature. Closes #11520. See #11462.
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark resolution:expired This issue was closed due to lack of feedback. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

2 participants