Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed excluding certain elements from CSS reset #11461

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

oleq
Copy link
Member

@oleq oleq commented Mar 14, 2022

Suggested merge commit message (convention)

Feature (theme-lark): Implemented a .ck-reset_all-excluded CSS class that excludes certain elements from CSS reset. Closes #11451.


Additional information

Demo in the manual test in the theme-lark package.

@oleq
Copy link
Member Author

oleq commented Mar 14, 2022

@ckeditor/qa-team Could you please check if this change does not break the UI of the editor? 🙏 The scope is vast, any piece of UI could be affected and there's no easy way to confirm that other than going through all guides/features (also in CF) 😬.

@dufipl
Copy link
Contributor

dufipl commented Mar 16, 2022

@oleq
We have tested this branch on docs on Chrome, Firefox and Safari and it looks good. Also, it does not look like it is breaking CF manual tests or collaboration samples so it looks good for us 👍

@Reinmar
Copy link
Member

Reinmar commented Mar 28, 2022

TODO @oleq add a note about this PR being a breaking change.

@oleq
Copy link
Member Author

oleq commented Mar 28, 2022

TODO @oleq add a note about this PR being a breaking change.

False alert. I thought using .ck.ck-reset_all * won't be possible but the I realized .ck stays in DOM so we're good. Sorry for the confusion.

@Reinmar
Copy link
Member

Reinmar commented Mar 28, 2022

What about the border-collapse style? It seems that it somehow leaks from... something.

@Reinmar
Copy link
Member

Reinmar commented Mar 28, 2022

Oleq explained to me that ☝️ is a dev tools issue.

All looks good then :)

@Reinmar Reinmar merged commit 8e3b902 into master Mar 28, 2022
@Reinmar Reinmar deleted the ck/11451-css-reset-exclude branch March 28, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research possibility to use donut CSS rule to exclude pieces of DOM from our CSS reset
3 participants