-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ckeditor5-react can be published in ES6 #105
Comments
cc @pomek |
I don't see any reason why we couldn't do that. All that we need to do is just remove All tests pass:
Will the change be a BC? @Reinmar, WDYT? |
The other question is why you need this transpilation. Because the support for IE11 is still an open issue and currently it does not work. |
Sounds fine to me. Although, I don't know what kind of implications this will have for people who use CKE5 in CRA apps. I guess none, because CKE5 is already ES6 there, so it already needs to be treated with Terser (instead of Uglify) and hence already require changing the configuration. Is that correct? No documentation changes will be required? |
No, we don't need to change anything. |
Let's do it then. |
Other: `<CKEditor>` React component will be distributed in ES6 instead of ES5. Closes #105.
CKEditor 5 Builds are published in the original ES6 format. If environment requires ES5, I need to transpile CKEditor 5 source to ES5 (ckeditor5 doc).
ckeditor5-react are published in ES5 format, so I need to manually filter ckeditor5-react build (in webpack config).
I think ckeditor5-react Builds should be published in ES6 format like other CKEditor 5 builds.
The text was updated successfully, but these errors were encountered: