Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Component will be distributed as ES6 #108

Merged
merged 1 commit into from
Sep 13, 2019
Merged

React Component will be distributed as ES6 #108

merged 1 commit into from
Sep 13, 2019

Conversation

pomek
Copy link
Member

@pomek pomek commented Aug 22, 2019

Suggested merge commit message (convention)

Other: <CKEditor> React component will be distributed in ES6 instead of ES5. Closes #105.


Additional information

Two things:

  • I am not sure how to define the merge message.
  • Should it be marked as BC?

cc: @Reinmar

@coveralls
Copy link

Pull Request Test Coverage Report for Build 201

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 199: 0.0%
Covered Lines: 41
Relevant Lines: 41

💛 - Coveralls

@Reinmar
Copy link
Member

Reinmar commented Sep 3, 2019

I'd like to wait with this for @ma2ciek.

@Reinmar
Copy link
Member

Reinmar commented Sep 3, 2019

  • Should it be marked as BC?

Yes. Definitely can be a breaking change to someone.

  • I am not sure how to define the merge message.

It was nearly fine. I edited your comment a bit.

@ma2ciek
Copy link
Contributor

ma2ciek commented Sep 13, 2019

Everything is working fine.

@ma2ciek ma2ciek merged commit ec34041 into master Sep 13, 2019
@ma2ciek ma2ciek deleted the t/105 branch September 13, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ckeditor5-react can be published in ES6
4 participants