-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with IE11 (Internet Explorer 11) #330
Comments
Unit tests: 2258 are passing. Most of failed tests are actually broken. Those not broken have most of the time the error:
I wasn't spending more time trying to find the source of such error, but that would be my starting point. Manual tests: Not a single manual test could be passed. Every time I get |
Super, thanks. It's usually a good news if many failed tests share the same error :D. |
There is a problem either in transpiler or in polyfill related to |
Interesting... this doesn't seem to be some tricky scenario so it's odd that Babel fails on that. How did you change it so it worked? |
Nah, |
@Reinmar Yes, |
So, I guess the next step would be to run |
Some other issues:
|
Yeah, good old browsers :|. I think that before we'll start fixing these issue we need to figure out how to do that without bloating the existing code. By the issues you found it seems that we need more polyfills for missing/outdated methods. I wonder if we can safely polyfill all these. |
Any chance first release of CKE5 will work in IE11? |
It depends. We don't know how far we are from making CKE5 really work in IE11. We'll check that after releasing 1.0.0 alpha and see if we'll be able to bring IE11 support for 1.0.0 final. |
Ok, thanks. Our decision whether to use CKE5 depends on it. Unfortunately we have many customers who are still using IE11 :/ |
|
Dear CK 5 team, first of all thanks a lot for putting so much effort into this editor. Here at OpenProject we just did a spike with it. The development of custom plugins is so much easier when compared with other editors. So my congratulations to your design decisions. Your editor is really awesome! Getting back to the IE 11 topic: Here at OpenProject we had a very similar discussion 2 years ago. We decided to drop support for IE 11. We had to make a decision whether we want to invest our time into the future or in the past. And we decided to invest into the future. Looking back I think it was the right decision. The browser landscape has changed dramatically in the last two years. We work for a large number of large corporates and governmental organizations. All of them are allowed to use modern browsers now. So if you ask them: Do we need to support IE 11 they all say Yes. If you ask them Are you allowed to use modern browsers they als say Yes. And if you ask them Do you want new features they also say Yes. And if you ask them Are you willing to pay the effort required to support IE 11 they say No. These people are slowing down the entire innovation by sticking to their legacy world. If application developers continue to support IE11 this will give them less pressure to move on. In my opinion more people would benefit from features such as table-support. Or legal requirements such as full accessibility. @wwalc and @Reinmar and @djanosik: wouldn't it be an option to provide (paid) long-term support for CK4 until the end of IE11 min 2020? And everybody who wants the new features of CK5 needs modern browsers? Again: Thanks a lot for all the hard work you for the community. I really appreciate that. |
@lindenthal I guess it would be ok to use CKE4. But how do I create headless CKE4 editor? CKE5 is modular and replacing UI with our own is quite easy.
|
Hi @djanosik, I do understand your concerns but please allow me to exaggerate a little so you can better understand my position. Actually you just confirmed my thesis: The development of modern web application is slown down by poorly maintained legacy applications. So people like the CKE developers, you and I have to suffer from that. And as I said: These companies that built up this technical debt try to hand over their problem to others. Which actually means that these companies are asking other open source developers to pay for their technical debt. But I guess there are many other opinions on that :-) Best |
I work in a field where IE11 is unfortunately still required, and customers can't easily upgrade. (Hospitals and other health) I haven't looked very much into what is actually broken with CKE5 under IE11, but I've had to deal with similar problems with polyfilling for IE11 in the past. There are a few conditionals, but supporting IE11 (through webpack magic) would probably be something I'd be willing to pay for, or to help look into and work on. |
I suggest you first upgrade to modern browsers and then upgrade to CK5. What is wrong with that approach? I have never heard anybody who said they can not use a modern Edge, Chrome or FF because of stability or security concerns. Do you? |
@lindenthal |
I guess you agree that FF and Chrome both work perfectly fine on Windows 7, right? The only reason to chose IE11 over FF are poorly maintained legacy web applications. I am not aware of any other reason. The point is: The more applications continue to support IE 11 the longer it will take to get rid of it. So by supporting IE 11 we make this problem even worse. You know there is another group of people that makes me even more angry: The people that request to support the combination of legacy browser with legacy screen readers (IE11 with JAWS 15). This combination really kills any UX and innovation. Did you ever see some of these people paying for the additional effort they create? |
@lindenthal The reason why I hope that CK5 will support IE is not cause of the browser:
|
Until the argument wether IE 11 shall or shall not be officially supported is closed, has anyone come up with a workaround solution using external polyfill libraries? |
I think anyone thinking IE11 support is not vital is not being realistic, I work for a large company that makes software for our customers a large number of them want IE11 support, I wish they didn’t but they do. Currently I am developing a completely new front end in which I would like to use ckeditor5 but I cannot because of no IE11 support. Additionally it sounds like the upgrade path from ckeditor4 to 5 is difficult and we will have issues converting our customers old data. This means not only do we have to use ckeditor4 but we will be stuck on ckeditor4 forever. |
To make it clear – while none of us personally want to work on adding support for IE11 (which feeling, I can see, you understand), it’s basically a matter of funding and opportunities for the project. You can always contact us (https://cksource.com/contact/) to discuss the options. I've missed this question previously:
The answer can be found in our Help center – "How long will CKEditor 4 be supported?
|
@long-lazuli asked a few questions how to start investigating IE11 support:
Please take a look at https://docs.ckeditor.com/ckeditor5/latest/builds/guides/integration/advanced-setup.html#option-building-to-es5-target. I hope it will help.
It depends and, TBH, it's hard to tell without digging. The first thing to do will be to:
The first two steps are provided by Babel polyfills. Then, there's a matter of finding or writing polyfills for HTML features we rely on or finding workarounds to not need them at all (will require PRs). Then, it'll get even darker and more smelly and you'll be chasing bugs and quirks of which it's plenty in IE11. At this stage, though, the editor should be quite usable already. Anyway... good luck :) PS. The best way to share your work and findings will be:
Thanks to that, the next person, or we, will be able to jump in and help. You can read more about out development env in https://docs.ckeditor.com/ckeditor5/latest/framework/guides/contributing/development-environment.html |
I am working on the ckeditor compatibility issue right now. After building editor for ES5 I got to the point mentioned by @Suraj151.
It seems that I stuck on it for a while, so I would appreciate any advice. |
I got to the same point a while ago and simply gave up. Anyone reading this: please do not make the same mistake I did: transpiling to ES5 will not magically give you IE11 support. CKEditor5 relies on browser APIs that are different or not available in IE. |
Any updates regarding this issue? |
We are just during the research about IE11 compatibility. Next week we will post the result of it. |
Hello everyone, we concluded the research about running CKEditor 5 on IE 11. In overall it is possible to provide a CKE5 build for IE 11 and after using some polyfills and quick fixes it loads and base features work (like typing). Collaboration features seem to be working too. Unfortunately, without further work, the editor is not stable enough to be used on production. Some of the important things that do not work:
And these are only some things that would need to be done. The research was promising in the sense that it proved that support for IE11 is feasible. However, it will require a significant effort to become anywhere close to “production ready” and we’re not currently able to fund it ourselves. Therefore, we don’t have any plans yet regarding any ETA as we’re still looking for company(ies) who be willing to share the cost of this project. If you want to play with CKE5 in IE 11, here is an instruction on how to create a build for IE 11. Only the classic editor was tested and available, although you could probably prepare other editors looking at changes done in
Keep in mind that If you are interested in what exactly has been changed, check which repositories are switched to If you’d like to pick this up and help with fixing issues on IE 11, you are most welcome to do so! |
(Thanks for you work on this... sadly IE11 is a "must have", so I'm told ... ) To be honest, I'm struggling with this: got so far as...
-- --- background - If it helps anyone: |
Ooops!
BTW. Why do you run |
So, can we get a status on IE11 support? where does it stand? did you guys ever brought it to a stable, production worthy state? |
@Yahav So far no companies were interested in sponsoring the work on IE11 compatibility - this is a blocker for us to move this issue forward because IE11 support requires a lot of work. So for now, we gave up after closing the research that @scofalik mentioned in his comment. |
Hi, |
Hello @wwalc , will IE11 be ever supported?. |
@Rialzista There is no progress regarding IE11 (by not spending time on it, we're able to move on and continue adding more new features: https://ckeditor.com/blog/CKEditor-5-v15.0.0-with-horizontal-line-page-break-responsive-toolbar-and-SVG-upload-support/) As for CKEditor 4: the official support for CKEditor 4 is until 2023. This is something that we committed to already, and for sure we will not end up the support earlier than that. Which gives you 4 years of peace of mind. Closer to that date we'd have a look at how the situation looks like and decide what next with CKEditor 4. |
This comment has been minimized.
This comment has been minimized.
Currently IE 11 is not supported and the CKEditor5 developers are not currently planning on adding support. ckeditor/ckeditor5#330 (comment)
Currently IE 11 is not supported and the CKEditor5 developers are not currently planning on adding support. ckeditor/ckeditor5#330 (comment)
Docs: Linked to the "Deep dive into focus tracking" from the FocusTracker class docs (see #6087).
This issue is no longer relevant as IE11 reaches the end of support as of June 2022. |
Long story short – CKEditor 5 doesn't work on IE11. Making it compatible with IE11 is a complex and long task – read more about the status of things and how you can help.
The text was updated successfully, but these errors were encountered: