Pin the Python package ansible-core to earlier than 2.16.3
#311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible-core 2.16.3 and later suffer from the bug discussed in ansible/ansible#82702, which breaks any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy.
jsf9k
added
bug
|
I believe the Snyk failure can be ignored, since we must pin in order for the code to function. |
10 tasks
jsf9k
requested review from
dav3r,
felddy,
jasonodoom and
mcdonnnj
as code owners
dv4harr10
approved these changes
Mar 8, 2024
mcdonnnj
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Thanks for hunting this down. One comment for your consideration and then a question: Should we do the same thing for cisagov/skeleton-ansible-role?
jsf9k
force-pushed
the
bugfix/pin-ansible-core
branch
2 times, most recently
from
68b5c50 to
99fda06
Compare
This issue reminds us to remove the pin against ansible-core when that becomes possible.
jsf9k
force-pushed
the
bugfix/pin-ansible-core
branch
from
99fda06 to
842e165
Compare
7 tasks
mcdonnnj
reviewed
Mar 10, 2024
Co-authored-by: Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request pins the
ansible-corePython package's version to earlier than 2.16.3.💭 Motivation and context
ansible-core2.16.3 and later suffer from the bug discussed in ansible/ansible#82702, which breaks any symlinked files invars,tasks, etc. for any Ansible role installed viaansible-galaxy. This results in AMI build failures as seen in cisagov/openvpn-packer#101.🧪 Testing
All automated testing passes in this pull request, and in cisagov/openvpn-packer#101 the build gets further than it did upon addition of these changes. (The build continues to fail, but for a different reason.)
✅ Pre-approval checklist