Pin ansible-core to earlier than 2.16.3

[jsf9k]

🗣 Description

This pull request pins the ansible-core Python package's version to earlier than 2.16.3.

💭 Motivation and context

ansible-core 2.16.3 and later suffer from the bug discussed in ansible/ansible#82702, which breaks any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy. This results, e.g., in AMI build failures as seen in cisagov/openvpn-packer#101.

🧪 Testing

All automated testing passes in this pull request, and in cisagov/openvpn-packer#101 the build gets further than it did upon addition of a similar change via cisagov/skeleton-packer#311. (The build continues to fail, but for a different reason.)

✅ Pre-approval checklist

• This PR has an informative and human-readable title.
• Changes are limited to a single goal - eschew scope creep!
• All future TODOs are captured in issues, which are referenced in code comments.
• All relevant type-of-change labels have been added.
• I have read the CONTRIBUTING document.
• These code changes follow cisagov code standards.
• All new and existing tests pass.

[dav3r]

👍 with one tiny change requested

[mcdonnnj]

LGTM ✔

[mcdonnnj]

@jsf9k Sorry this only came to me yesterday but I would like to add a dependabot ignore directive for this newly explicit dependency here:

skeleton-ansible-role/.github/dependabot.yml

Lines 27 to 30 in 1666745

	# ignore:
	# # Managed by cisagov/skeleton-ansible-role
	# - dependency-name: ansible
	# - dependency-name: ansible-lint

I don't know if it's strictly necessary but I would like to avoid a storm of dependabot PRs around this dependency downstream.

[jsf9k]

@jsf9k Sorry this only came to me yesterday but I would like to add a dependabot ignore directive for this newly explicit dependency here:

skeleton-ansible-role/.github/dependabot.yml

Lines 27 to 30 in 1666745

	# ignore:
	# # Managed by cisagov/skeleton-ansible-role
	# - dependency-name: ansible
	# - dependency-name: ansible-lint

I don't know if it's strictly necessary but I would like to avoid a storm of dependabot PRs around this dependency downstream.

Please see commit 13219ff.

[mcdonnnj]

Approval intensifies.

[jsf9k]

See also cisagov/skeleton-packer#315.