Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert ansible-core pin when that becomes possible #178

Closed
jsf9k opened this issue Mar 10, 2024 · 1 comment · Fixed by #193
Closed

Revert ansible-core pin when that becomes possible #178

jsf9k opened this issue Mar 10, 2024 · 1 comment · Fixed by #193
Assignees
@jsf9k
Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@jsf9k
Copy link
Member

jsf9k commented Mar 10, 2024 •
edited
Loading

💡 Summary

The ansible-core pin in requirements.txt should be removed when and if that becomes possible.

Note that the pin must also be reverted in cisagov/skeleton-generic and cisagov/skeleton-packer, as it is reproduced there in .pre-commit-config.yaml in cisagov/skeleton-generic#180 and in requirements.txt in cisagov/skeleton-packer#311, respectively.

See also:

Motivation and context

ansible-core 2.16.3 and later currently suffer from the bug discussed in ansible/ansible#82702, which breaks any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy. Once this issue is addressed the pin can be removed.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Mar 10, 2024
jsf9k added a commit to cisagov/skeleton-packer that referenced this issue Mar 10, 2024
@jsf9k
Mention the related issue cisagov/skeleton-ansible-role#178
99fda06
jsf9k added a commit to cisagov/skeleton-packer that referenced this issue Mar 10, 2024
@jsf9k
Mention the related issue cisagov/skeleton-ansible-role#178
842e165
mcdonnnj added a commit to cisagov/cyhy_amis that referenced this issue Mar 12, 2024
@mcdonnnj @jsf9k
Pin ansible-core to earlier than 2.16.3
e3af65c 
As described in cisagov/skeleton-ansible-role#178 this is a breaking
bug for how we use Ansible with Ansible roles.

Co-authored-by: Shane Frasier <[email protected]>
jsf9k added a commit to cisagov/openvpn-packer that referenced this issue Mar 13, 2024
@jsf9k
Mention the related issue cisagov/skeleton-ansible-role#178
227ea44
@jsf9k jsf9k mentioned this issue Mar 27, 2024
Closed
mcdonnnj added a commit to cisagov/cyhy_amis that referenced this issue Apr 5, 2024
@mcdonnnj @jsf9k
Pin ansible-core to earlier than 2.16.3
fd24b4b 
As described in cisagov/skeleton-ansible-role#178 this is a breaking
bug for how we use Ansible with Ansible roles.

Co-authored-by: Shane Frasier <[email protected]>
@jsf9k jsf9k mentioned this issue Apr 22, 2024
Closed
@jsf9k jsf9k self-assigned this May 3, 2024
@jsf9k
Copy link
Member Author

jsf9k commented May 3, 2024

The next release of ansible-core should unbreak this thanks to ansible/ansible#82911.

This was referenced May 4, 2024
Closed
Closed
Closed
@jsf9k jsf9k mentioned this issue May 21, 2024
Merged
6 tasks
@jsf9k jsf9k moved this from To do to In progress in Skeleton Maintenance May 22, 2024
@jsf9k jsf9k added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label May 24, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Skeleton Maintenance Jun 1, 2024
cisagovbot pushed a commit that referenced this issue Sep 25, 2024
@mcdonnnj
Merge pull request #178 from cisagov/improvement/add_pre-commit_meta_…
28dc4ce 
…hook

Add the `check-useless-excludes` hook to the pre-commit configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsf9k jsf9k

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update version pin on ansible-core Python package cisagov/skeleton-ansible-role
1 participant
@jsf9k