Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#508) Enable download progress in NuGet #2964

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

TheCakeIsNaOH
Copy link
Member

@TheCakeIsNaOH TheCakeIsNaOH commented Jan 11, 2023

Description Of Changes

This enables the download progress message output from NuGet.

Motivation and Context

See chocolatey/NuGet.Client#12

If any other downloads of .nupkg files are added, then a similar line should be added before the download to enable the download progress

Testing

  • Build nuget libraries
  • Set Chocolatey to use them
  • Run .\choco install wget --force
  • Run .\choco install wget --force --no-progress
  • Run .\choco install WGETWindows --force --source=https://api.nuget.org/v3/index.json
  • Run .\choco install WGETWindows --force --source=https://api.nuget.org/v3/index.json --no-progress
  • Validate that download is progress is shown or not shown as appropriate.

Operating Systems Testing

  • Windows 10 22H2

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Part of #508
Enablement of chocolatey/NuGet.Client#12
https://app.clickup.com/t/20540031/PROJ-430

@choco-bot
Copy link

@TheCakeIsNaOH TheCakeIsNaOH marked this pull request as draft January 11, 2023 16:34
@TheCakeIsNaOH
Copy link
Member Author

TheCakeIsNaOH commented Jan 11, 2023

This is draft, as it depends on the NuGet libraries being updated to a build that includes download progress. Edit: merged

@TheCakeIsNaOH TheCakeIsNaOH marked this pull request as ready for review January 12, 2023 17:10
@TheCakeIsNaOH TheCakeIsNaOH requested a review from gep13 January 12, 2023 17:10
This enables the download progress message output from
NuGet. If any other downloads of .nupkg files are added,
then a similar line should be added before the download
to enable the download progress
@gep13 gep13 force-pushed the download-progress branch from 1c25625 to 17e320a Compare January 13, 2023 10:46
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Jan 13, 2023

@TheCakeIsNaOH thanks for getting this added!

@gep13 gep13 merged commit 7788542 into chocolatey:develop Jan 13, 2023
@gep13
Copy link
Member

gep13 commented Jan 13, 2023

@TheCakeIsNaOH thanks for getting this added!

@TheCakeIsNaOH TheCakeIsNaOH deleted the download-progress branch January 13, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants