(#9) Add Download Progress #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCakeIsNaOH
force-pushed
the
download-progress
branch
2 times, most recently
from
f311ec5 to
aa8369e
Compare
This adds download progress to the console when ChocolateyProgressInfo.ShouldDisplayDownloadProgress is set to true. It works for both v2 and v3 feeds, but does not display for local feeds.
TheCakeIsNaOH
force-pushed
the
download-progress
branch
from
aa8369e to
a3f63ae
Compare
46 tasks
|
@TheCakeIsNaOH I have rebsased/merged this here: f112d53 since I wasn't able to push changes back to your branch. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This adds download progress to the console when
ChocolateyProgressInfo.ShouldDisplayDownloadProgressis set to true. It works for both v2 and v3 feeds, but does not display for local feeds.Motivation and Context
Feature parity with v1
Testing
ChocolateyProgressInfo.ShouldDisplayDownloadProgress = config.Features.ShowDownloadProgress;here:https://github.com/chocolatey/choco/blob/cdd1c0036f4c092625886d71fbff2e628b838742/src/chocolatey/infrastructure.app/services/NugetService.cs#L747
.\choco install wget --force.\choco install wget --force --no-progress.\choco install WGETWindows --force --source=https://api.nuget.org/v3/index.json.\choco install WGETWindows --force --source=https://api.nuget.org/v3/index.json --no-progressOperating Systems Testing
Change Types Made
Change Checklist
Related Issue
https://app.clickup.com/t/20540031/PROJ-430