Fix https://github.com/NuGet/Home/Issues/1408 #9

yishaigalatzer · 2015-10-05T20:23:17Z

The fix is about making vssettings not throw if the solution doesn't have a folder attached to it.
This happens when there is no solution open, but there is a single file open, which creates s misc files solution.

Also see:
NuGetArchive/NuGet.VisualStudioExtension@ba0a129

The fix is about making vssettings not throw if the solution doesn't have a folder attached to it. This happens when there is no solution open, but there is a single file open, which creates s misc files solution. Also see: NuGetArchive/NuGet.VisualStudioExtension@ba0a129

yishaigalatzer · 2015-10-13T20:30:07Z

Already merged from 3.2.1 branch d4a128f

To make them specific to Chocolatey, and therefore limit possible collisions with existing packages.

Extend Nuspec metadata to include: - Project source url - Package source url - Docs url - Wiki Url - Mailing List Url - Bug Tracker Url Adding the following elements, reserving for future use with respect to package relationships. - Replaces - Provides - Conflicts This brings forward these commits: chocolatey/nuget-chocolatey@9b703a8 chocolatey/nuget-chocolatey@4e28997 chocolatey/nuget-chocolatey@b9c4bc5 Co-Authored-By: Rob Reynolds <[email protected]>

Along with moderation related information, provide other data that is provided by the server metadata. - PackageHash - PackageHashAlgorithm - PackageSize - VersionDownloadCount - IsApproved - PackageStatus - PackageSubmittedStatus - PackageTestResultStatus - PackageTestResultStatusDate - PackageValidationResultStatus - PackageValidationResultDate - PackageCleanupResultDate - PackageReviewedDate - PackageApprovedDate - PackageReviewer - IsDownloadCacheAvailable - DownloadCacheDate - DownloadCache Based on these commits: chocolatey/nuget-chocolatey@3866411 chocolatey/nuget-chocolatey@133552a Co-Authored-By: Rob Reynolds <[email protected]>

Allow passing a specific proxy into the proxy cache that is used no matter what. Based on these commits: chocolatey/nuget-chocolatey@4b206ed chocolatey/nuget-chocolatey@26559a4 Co-Authored-By: Rob Reynolds <[email protected]> Co-Authored-By: Jakub Cisło <[email protected]>

Exposing these allows more efficient direct usage.

As Chocolatey, we never want to create the NuGet.Config file, as this is not used by Chocolatey at all. As such, rather than GetOrCreateDocument, if the filepath doesn't exist, simply return the default empty XDocument, which is exactly what would have been returned after creating the file. A few tests have to be skipped, as they rely on the config being automatically created. Based on this commit: chocolatey/nuget-chocolatey@a211f19 Co-Authored-By: Gary Ewan Park <[email protected]>

Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d

This adds the Chocolatey strongname keypair used for nuget-chocolatey and switches the sign.target to use it. This requires that the InternalsVisibleTo properties be updated with the new public key. Keyfile from: chocolatey/nuget-chocolatey@7e8d686

This strips empty entries from a string with multiple entries split by a separator. Brought forward from: chocolatey/nuget-chocolatey@d344d47 Co-Authored-By: Rob Reynolds <[email protected]>

This pulls an interface out of HttpSource called IHttpSource, and switches usages to use the interface. Additionally, it adds a method to HttpSourceResource to allow the IHttpSource to be switched out if needed, so alternative implementations can be used. Based on these commits: chocolatey/nuget-chocolatey@19986e7 chocolatey/nuget-chocolatey@ee5f731e Co-Authored-By: Rob Reynolds <[email protected]>

This is to allow not deleting directory This allows added files to be not deleted during package upgrades.

If you don't set it specifically, after ILMerge the NuGet libraries will show up as having Chocolatey's version. This affects the user agent, and other uses of the library version. Brought forward from this commit: chocolatey/nuget-chocolatey@2a0aa36 Co-Authored-By: Rob Reynolds <[email protected]>

This reverts commit 9c264ed.

To be Chocolatey.NuGet.Frameworks. Due to a transitive dependency from one of the Microsoft Unit Testing libraries on the NuGet.Frameworks NuGet package, it wasn't possible to directly renamed the NuGet.Frameworks project to Chocolatey.NuGet.Frameworks in the same way that we have done the other projects. When we tried this, there was a conflict between the assemblies, and it wasn't possible to compile. We attempted to use the standard solutions like introduce an app.config file to redirect the binding, but none of these approches worked. Various solutions were put forward, including using an assembly alias and extern inclusion, as well as completely removing the NuGet.Frameworks project reference in favour of the upstream NuGet.Frameworks NuGet package, but all of these were rulred out in favour of renaming the project and the assemblies, and then updating the using statements and various other places where the name is used. It is understood that there will likely be similar changes required when we pull in upstream code from the NuGet.Client GitHub repository.

Two project package ids were changed to make them Chocolatey specific when this wasn't required. This commit reverts the rename, and puts them back to the other NuGet specific package id.

To ensure that any new files are stamped with Chocolatey Software, Inc, and any files that we have edited have both .Net Foundation and Chocolatey Software, Inc.

This reverts commit b400373. # Conflicts: # src/NuGet.Clients/NuGet.SolutionRestoreManager/Properties/AssemblyInfo.cs

This adds download progress to the console when ChocolateyProgressInfo.ShouldDisplayDownloadProgress is set to true. It works for both v2 and v3 feeds, but does not display for local feeds.

Now that we are pushing our own version of the nupkgs to NuGet.org, we should update the nupkg information (including the icon) to be more Chocolatey specific. This is with an effort to ensure that there is no ambiguity about what this package's intend use is.

This prevents any configuration from nuget.config files being returned to prevent NuGet configuration from tainting Chocolatey

In addition to being able to list out the packages from a search on a feed, it is also necessary to know the numbers of packages that are available, so that correct paging can be applied in applications like Chocolatey GUI. This commit add a SearchCountAsync method with an implementation for for v2 and v3 feeds. It is believed that the v3 feed will need additional work, but this implementation is aimed at getting things working in Chocolatey GUI, when using v2 feeds, so additional work will be done in follow up commits. Co-authored-by: TheCakeIsNaOH <[email protected]>

When a package search resource is returned, it should first check to see if the feed that is being accessed has the capabilities to perform the search. If this is not done, saerches can be emitted against a feed which will fail. A similar check is performed when using a listResource so this commit does something very similar for a searchResource. Within this commit, a NullLogger is used, which isn't ideal, but without additional work, and refactoring, this has been deemed as ok for now. A follow up issue will be created to try to remove the usage of this NullLogger. Co-authored-by: TheCakeIsNaOH <[email protected]>

Within the Chocolatey codebase, there is some explicit handling done of a serialized instance of the NuGetVersion class into XML. Without a converter to handle this work, some aspects of the codebase fails to work correctly. This commit adds a new NuGetVersionConverter class which is very similar to the existing SemanticVersionConverter class, and adds an attribute to the NuGetVersion class so that upstream users know which class to use when converting instances of this class.

To help with the serializing and deserializing of the LicensedChocolateyConfiguration class, we need to mark these classes are serializable.

Chocolatey only uses a portion of the projects that the NuGet.Client.sln includes. This commit adds a slnf file with only the projects, and associated test projects, that Chocolatey is using. This makes it much faster to load and build the projects, as we aren't building projects that we aren't using/editing.

While testing some functionality of a v2 feed, it was found that the DownloadCache property wasn't getting set. Tracing this back through, it was found that setting of this property wasn't being done in the same place as other properties. This commit adds this in, but it hasn't done a sweep to ensure that other properties haven't also been missed. This was found during testing, and simply needs to be fixed now, and later we can do a complete sweep of all properties.

We are going to need to alter how these methods work in Chocolatey Licensed, and the easiest way to do that is to mark them as virtual, so that we can override them in a derived class.

In the original warning, which is displayed when a package dependency is missing for the currently installed packages, it mentions a packages.config file. This makes sense in the context of NuGet, but not in the context of Chocolatey. The wording has been changed to make it clear that the warning related to the packages contained within the Chocolatey lib folder.

This overload includes an additional parameter for includePrerelease, to determine whether prerelease packages should be returned or not. For Chocolatey, prerelease packages should only be included if the --pre argument is used. This commit addresses an issue when installing Chocolatey GUI, where the dotnetfx dependency is resolved to be the prerelease version, when it shouldn't be.

When Chocolatey is ran with the --order-by-popularity option, the expectation is that the DownloadCount property is pass within the oData query. This is done, however, on further comparison between what is emitted from Chocolatey 1.x, and the new 2.x version, it was found that there was a missing follow up ordering, based on the Id. In addition, the direction of the order for DownloadCount, should be explicit. i.e. rather than adding DownloadCount to the query string, we need to add DownloadCount%20desc,Id (here %20 is the HTML encoded value for a space character). This commit update the orderBy variable to contain the requirement order by value, when DownloadCount is being applied.

When searching by version number in the 1.x version of Chocolatey, an additional orderby of "Id, Version desc" is included. In order to maintain backwards compatibility, we need to also include this orderby in the new NuGet.Client based implementation. This work is similar to the work that was done in this commit, where the DownloadCount orderby was added: chocolatey@d28424e This commit adds the Version property to SearchOrderBy, which can then be used within chocolatey/choco codebase, when required.

When searching by both downloadcount (i.e. the order-by-popularity option) and for a specific version, it makes sense to combine the order by into something like: DownloadCount desc, Id, Version desc rather than simply by version, or by download count. Ideally, we would be able to combine the orderby terms based on which enumeration values are selected, however, then the order of them can't be controlled. This commit adds a new DownloadCountAndVersion property to the SearchOrderBy to allow specifically stating that this order by is required.

Rather than using Id as the default orderby, change to use Id, Version desc.

When fetching information about a single package, in order to find out the highest available version, NuGet.Client normally has to make multiple calls via the FindPackagesById method, in order to get all package versions, and to then determine which was is highest. To short circuit this, and make only one call, it is possible to use the Packages() endpoint, providing the exact id to search for, as well as whether it should include prereleases or not. This commit adds a new PackageAsync method to the ListResource, which can then be used to find out the highest available version of a particular package using one API call. This can then be consumed within the Chocolatey/choco codebase, when the UsePackageRepositoryOptimizations option is set, which makes it behave in the same way as the 1.x version of Chocolatey.

When using the SearchResource for a local packages feed, there is no ordering of the packages that are returned. As a result, when the CollapseToHighestVersion method (which assumes that the packages are in Id order) is called, it is possible that the incorrect package version for the highest available package is returned. To prevent this, we need to ensure that when calling the CollapseToHighestVersion method we first order the packages based on the Identity.Id. This problem arose when we switched from using the ListResource.ListAsync method to the SearchResource.SearchAsync method by default. The first correctly ordered the packages that are returned, but the other doesn't, and this manifested itself by some failing integration tests when running on MacOS.

This commit updates the legacy capabilities resource to store whether the feed has the endpoint FindPackagesById available or not. There are some feeds we are aware of that does not include this endpoint, and we need to be able to support calls to these feeds. As such we need to store the capabilities available for the endpoint.

…dpoint This commit adds a fallback to make use of the Packages() endpoint when the feed that is being used does not report that it supports the use of the FindPackagesById endpoint. This is needed as a fallback as there are some feeds available that does not implement FindPackagesById.

(NuGet#9) Check whether FindPackagesById is supported for a feed

When the prerelease option is included in the outgoing query, a decision is made about including either IsLatestVersion is IsAbsoluteLatestVersion in the query. However, in the case where preelease is true and the feed being queried doesn't support IsAbsoluteLatestVersion, the IsLatestVersion is included in the query. This is deemed as wrong, since it is the exact opposite of what is being asked for. This commit addresses this issue specifically by only including IsLatestVersion when explicitly not asking for prerelease. We believe that this will prevent confusion when folks are using Chocolatey. In addition, when doing the PackageAsync call, when we can't use IsLatestVersion or IsAbsoluteLatestVersion, defer to using a new helper method FindPackageByIdAsync which was introduced in another scope of work, to selectively search for a package given the searchTerm then order by version, and return the highest. This is required, since the query can potentially return more than more result, which is not desired. In order to use this method, it was necessary to further extend the IV2FeedParser to include the method definition.

In order to make the most optimal oData queries, we need to ensure that we are only asking for the information that meets our needs. For example, when using the command line options for --by-id-only, or --by-tag-only, or --id-starts-with, we should add this information into the oData query that is sent out. This commit adds this into the queries (it will require an additionl change into the chocolatey/choco codebase to make use of it), and makes the resulting queries similar to what is sent out in 1.x of choco.exe.

In a previous commit, the BuildFieldSearchFilter method was extended to include additional filter options for things like ByIdOnly, ByTagOnly and IdStartsWith. When this method was extened, it was also updated to only include property clauses if explicitly asked for, since this is how the function used to work. In doing this, the return value was chosen as string.Empty, which felt like the right choice. However, in later processing, checks for null were done, and not an empty string, which then causes problems in how the oData query was constructed. This commit address that issue by changing the return type from string.Empty to null.

In a previous commit, changes were made to allow the execution of a count query, to get information back about the number of packages that meet a specific query. During testing, it was found that this query, which included usage of the skip and top options, wasn't working as expected when hitting a Nexus Repository v2 feed. Instead of returning the number of packages, it would instead return the number that was included in the top parameter, which was hard-coded to 1. This then caused a problem when using Chocolatey GUI, since Chocolatey GUI needs to know the total number of packages for a query, so that it can set up the necessary paging within the application to see all the results. This commit alters the V2FeedQueryBuilder class to have a completely separate format string for the count query, rather than trying to use the existing search format string. This means that there is clear segregation between the format strings is use, and we can then easily remove the problematic skip/top options. It should be noted that other repository servers did not have a problem with these extra options, it was only found that Nexus did. However, this change also makes the count query the same as the one that was emitted by Chocolatey CLI 1.x, so it makes sense to move forward with this change.

* release/3.0.0: (build) Only build projects required by Chocolatey Revert "(build) Attempt to fix failing build" (build) Attempt to fix failing build (NuGet#9) Alter query emitted when doing a count query

* release/3.0.0: (138 commits) (maint) Update shipped API's (doc) Add not about paramter for ChocolateyBuild (build) Only build projects required by Chocolatey Revert "(build) Attempt to fix failing build" (build) Attempt to fix failing build (NuGet#9) Alter query emitted when doing a count query (build) Switch to creating beta packages (NuGet#9) Change return value from method (NuGet#9) Optimize queries when using extra options (NuGet#9) Alter filter construction for prereleases (NuGet#9) Add fallback to packages endpoint on missing findpackagesendpoint (NuGet#9) Update capabilities to check for FindPackagesById (maint) Fix Chocolatey solution filter (NuGet#9) Ensure correct order for packages (NuGet#9) Add new PackageAsync method to ListResource (NuGet#9) Change default orderby for listResource (maint) FIx spelling mistake (NuGet#9) New order by for version and downloadcount (NuGet#9) New order by for version searching by version (NuGet#9) Fix DownloadCount ordering ...

# This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup

# This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup # This is the commit message #21: cleanup # This is the commit message #22: cleanup # This is the commit message #23: oops # This is the commit message #24: Clean up # This is the commit message #25: undo

# This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup

# This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup # This is the commit message #21: cleanup # This is the commit message #22: cleanup # This is the commit message #23: oops # This is the commit message #24: Clean up # This is the commit message #25: undo

# This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup # This is the commit message #21: cleanup # This is the commit message #22: cleanup # This is the commit message #23: oops # This is the commit message #24: Clean up # This is the commit message #25: undo # This is the commit message #26: cleanup # This is the commit message #27: cleanup # This is the commit message #28: # This is a combination of 20 commits. # This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup

dnfclas added the cla-already-signed label Oct 5, 2015

yishaigalatzer closed this Oct 13, 2015

yishaigalatzer deleted the Bug1408 branch October 28, 2015 21:34

TheCakeIsNaOH added a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Nov 28, 2022

(NuGet#9) Change package IDs

245be19

To make them specific to Chocolatey, and therefore limit possible collisions with existing packages.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Nov 28, 2022

(NuGet#9) Expose NuspecReader and PackagePath

0881279

Exposing these allows more efficient direct usage.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Nov 28, 2022

(NuGet#9) Add overload to FolderNuGetProject.DeletePackage

3a2dc05

This is to allow not deleting directory This allows added files to be not deleted during package upgrades.

TheCakeIsNaOH pushed a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Dec 13, 2022

Revert "(NuGet#9) Switch to Chocolatey strongname key"

b400373

This reverts commit 9c264ed.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Jan 9, 2023

(NuGet#9) Skip file location migrations

6e0c01c

TheCakeIsNaOH added a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Jan 9, 2023

(NuGet#9) Switch to Chocolatey specific paths for environment folders

5769cd9

TheCakeIsNaOH added a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Jan 10, 2023

(NuGet#9) Return null for configuration elements

9bca314

This prevents any configuration from nuget.config files being returned to prevent NuGet configuration from tainting Chocolatey

TheCakeIsNaOH pushed a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Feb 3, 2023

(NuGet#9) Mark classes as serializable

c17ee3d

To help with the serializing and deserializing of the LicensedChocolateyConfiguration class, we need to mark these classes are serializable.

TheCakeIsNaOH pushed a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Jun 2, 2023

(NuGet#9) Change default orderby for listResource

4b6acf1

Rather than using Id as the default orderby, change to use Id, Version desc.

TheCakeIsNaOH pushed a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Jun 2, 2023

Merge pull request NuGet#31 from AdmiringWorm/find-packages-capabilities

d79e7c5

(NuGet#9) Check whether FindPackagesById is supported for a feed

nkolev92 mentioned this pull request Jul 14, 2023

Improve hashing and equality allocations/performance #5304

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix https://github.com/NuGet/Home/Issues/1408 #9

Fix https://github.com/NuGet/Home/Issues/1408 #9

yishaigalatzer commented Oct 5, 2015

yishaigalatzer commented Oct 13, 2015

Fix https://github.com/NuGet/Home/Issues/1408 #9

Fix https://github.com/NuGet/Home/Issues/1408 #9

Conversation

yishaigalatzer commented Oct 5, 2015

yishaigalatzer commented Oct 13, 2015