Implementing the top panel according to the new UI design. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshots the same as the ones you see on NuGet/Home#1430. |
|
|
||
| [SuppressMessageAttribute("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode", | ||
| Justification = "It is referenced by the xaml file")] | ||
| private void FilterLabel_ControlSelected(object sender, EventArgs e) |
There was a problem hiding this comment.
let change this method to public and remove the suppress
|
|
1 similar comment
|
|
| } | ||
|
|
||
| private void _labelText_MouseLeave(object sender, MouseEventArgs e) | ||
| { |
There was a problem hiding this comment.
Should this be simplified to be the following? Since, you already set the brush on mouse enter?
if (!_selected)
{
_labelText.SetResourceReference(
TextBlock.ForegroundProperty,
Brushes.UIText);
}
|
Looks good to me |
|
Changed per feedbacks. Merged into dev. |
| set | ||
| { | ||
| _count = value; | ||
| if (_count > 0) |
There was a problem hiding this comment.
extra empty line below _count
TheCakeIsNaOH
pushed a commit
to TheCakeIsNaOH/NuGet.Client
that referenced
this pull request
Jun 2, 2023
Nigusu-Allehu
added a commit
that referenced
this pull request
Oct 22, 2024
# This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup # This is the commit message #21: cleanup # This is the commit message #22: cleanup # This is the commit message #23: oops # This is the commit message #24: Clean up # This is the commit message #25: undo # This is the commit message #26: cleanup # This is the commit message #27: cleanup # This is the commit message #28: # This is a combination of 20 commits. # This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of issue NuGet/Home#1430