Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISM /all doesn't run anywhere but Windows 6.2 -- no dependencies get installed #897

Closed
jrkd opened this issue Aug 9, 2016 · 1 comment
Closed

DISM /all doesn't run anywhere but Windows 6.2 -- no dependencies get installed #897

jrkd opened this issue Aug 9, 2016 · 1 comment
Assignees
@ferventcoder
Labels
5 - Released Bug Up For Grabs
Milestone
0.10.0

Comments

@jrkd
Copy link
Contributor

jrkd commented Aug 9, 2016

Running choco on windows 10.0.x with source windowsfeatures, there's a problem with installing dependencies to a particular feature.

Looks like the issue is in /src/chocolatey/infrastructure.app/services/WindowsFeatureService.cs Line 230, where the condition to add the all argument requires the minor version of windows to always be greater than 2, no matter the major version.

Will add a pull request with a suggested fix to this issue.
jrkd added a commit to jrkd/choco that referenced this issue Aug 9, 2016
@jrkd
Merge pull request #1 from jrkd/chocolateyGH-897-Issue-with-dependenc…
1460db0 
…ies-on-windows-10.0

(chocolateyGH-897) gism ... /all was never running for source windowsfeatures
@ferventcoder ferventcoder changed the title gism /all is never running -- no dependencies get installed. dism /all is never running -- no dependencies get installed. Aug 9, 2016
@jrkd jrkd mentioned this issue Aug 9, 2016
Closed
@ferventcoder ferventcoder added this to the 0.10.0 milestone Aug 9, 2016
@ferventcoder ferventcoder self-assigned this Aug 9, 2016
ferventcoder pushed a commit that referenced this issue Aug 10, 2016
@jrkd @ferventcoder
(GH-897) Fix DISM /all for newer Windows versions
a5918ef 
DISM /all was never running for source windowsfeatures due to only running on
Windows 6.2.

The issue here was minor version was always required to be > 2, so now that
we're at windows 10.0.x /all is not being added, even though this logic really
only wanted to make sure the version was >= 6.2

Added a check to see if the version is greater than 6 entirely, if not, only
then does it check if its version 6 and at least minor ver. 6.2.

Not calling /all as part of DISM meant that dependencies for windows features
were never installed as part of the installation.
ferventcoder added a commit that referenced this issue Aug 10, 2016
@ferventcoder
Merge branch 'pr898' into stable
e428c85 
* pr898:
  (GH-897) Fix DISM /all for newer Windows versions
ferventcoder added a commit that referenced this issue Aug 10, 2016
@ferventcoder
Merge branch 'stable'
459d60d 
* stable: (23 commits)
  (GH-897) Fix DISM /all for newer Windows versions
  (maint) bring back in nuspec into solution folders
  (GH-598) Add output directory for choco pack
  (version) bump to 0.10.0
  (doc) update CHANGELOG/nuspec
  (GH-840) Do not set User Environment for SYSTEM
  (GH-840) Set TMP to cacheLocation as well
  (GH-830) Ensure process PSModulePath items
  (GH-112) Relax HTTPS checksum failure
  (maint) move noop run
  (GH-833) Don't set profile under certain conditions
  (doc) update generated docs
  (GH-112) update options for new version
  (GH-112) Checksums / Install Template
  (GH-112) Update parameter documentation
  (GH-112) Require checksums
  (GH-112) Allow Empty Checksums
  (GH-112) Checksum remote files unless checksum
  (GH-112) Allow user passed checksums
  (GH-112) rename checksum files for proper casing
  ...
@ferventcoder
Copy link
Member

ferventcoder commented Aug 10, 2016 •
edited
Loading

Merged into stable at e428c85 to release in 0.10.0.

@ferventcoder ferventcoder changed the title dism /all is never running -- no dependencies get installed. DISM /all doesn't run anywhere but Windows 6.2 -- no dependencies get installed Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Up For Grabs
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @jrkd