Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pack - Add optional output folder option #598

Closed
laedit opened this issue Feb 1, 2016 · 9 comments
Closed

Pack - Add optional output folder option #598

laedit opened this issue Feb 1, 2016 · 9 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement Priority_LOW Up For Grabs
Milestone
0.10.0

Comments

@laedit
Copy link
Contributor

laedit commented Feb 1, 2016

Like nuget pack it could be useful to have the -OutputDirectory option.
@ferventcoder
Copy link
Member

possible dupe of #173

@ferventcoder ferventcoder mentioned this issue Feb 1, 2016
Closed
@ferventcoder
Copy link
Member

Actually, just related to. We'll work on adding this behavior as part of this ticket.

@ferventcoder ferventcoder added this to the 0.9.10.x milestone Feb 1, 2016
@gep13
Copy link
Member

gep13 commented Feb 1, 2016

When this gets added, I will update the Cake integration to add this additional parameter to the ChocolateyPack command that it has.

@laedit
Copy link
Contributor Author

laedit commented Feb 2, 2016

Since it is up for grabs, I volunteer to contribute.
If I understand, the evolution will consist to add a PackCommandConfiguration in ChocolateyConfiguration with a OutputDirectory property and use it from the command to the NugetService.

@ferventcoder
Copy link
Member

Not quite, we already have an output directory? If not, then yes.

@ferventcoder
Copy link
Member

Output directory at top level, not inside of the other commands that is.

@laedit
Copy link
Contributor Author

laedit commented Feb 3, 2016

Since it can be used by other command (like new in #448) I wonder if it's preferable to add the OutputDirectory property to ChocolateyConfiguration directly and not in a subcommand configuration?

@ferventcoder
Copy link
Member

I think it would be good as a top level configuration, but perhaps each command has to opt in to offering it though.

This was referenced Feb 4, 2016
Closed
Closed
@laedit laedit mentioned this issue Aug 3, 2016
Closed
@ferventcoder ferventcoder modified the milestones: 0.9.10.4, 0.9.10.x Aug 3, 2016
@ferventcoder ferventcoder self-assigned this Aug 3, 2016
ferventcoder pushed a commit that referenced this issue Aug 10, 2016
@ferventcoder
(GH-598) Add output directory for choco pack
f1cc33d 
Add a new option outputdirectory for PackCommand and the corresponding
OutputDirectory property in ChocolateyConfiguration.
ferventcoder added a commit that referenced this issue Aug 10, 2016
@ferventcoder
Merge branch 'pr891' into stable
4da5a6f 
* pr891:
  (GH-598) Add output directory for choco pack
ferventcoder added a commit that referenced this issue Aug 10, 2016
@ferventcoder
Merge branch 'stable'
459d60d 
* stable: (23 commits)
  (GH-897) Fix DISM /all for newer Windows versions
  (maint) bring back in nuspec into solution folders
  (GH-598) Add output directory for choco pack
  (version) bump to 0.10.0
  (doc) update CHANGELOG/nuspec
  (GH-840) Do not set User Environment for SYSTEM
  (GH-840) Set TMP to cacheLocation as well
  (GH-830) Ensure process PSModulePath items
  (GH-112) Relax HTTPS checksum failure
  (maint) move noop run
  (GH-833) Don't set profile under certain conditions
  (doc) update generated docs
  (GH-112) update options for new version
  (GH-112) Checksums / Install Template
  (GH-112) Update parameter documentation
  (GH-112) Require checksums
  (GH-112) Allow Empty Checksums
  (GH-112) Checksum remote files unless checksum
  (GH-112) Allow user passed checksums
  (GH-112) rename checksum files for proper casing
  ...
@ferventcoder
Copy link
Member

Merged into stable at 4da5a6f to release in 0.10.0.

@gep13 gep13 mentioned this issue Aug 10, 2016
Closed
@ferventcoder ferventcoder changed the title Add possibility to set an output folder for choco pack Pack - Add optional output folder option Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement Priority_LOW Up For Grabs
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
3 participants
@ferventcoder @laedit @gep13