(GH-897) dism ... /all was never running for source windowsfeatures #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue here was minor version was always required to be > 2, so now that we're at windows 10.0.x /all is not being added, even though this logic really only wanted to make sure the version was >= 6.2 Added a check to see if the version is greater than 6 entirely, if not, only then does it check if its version 6 and at least minor ver. 6.2. Not calling /all as part of gism meant that dependencies for windows features were never installed as part of the installation.
|
Have now signed the CLA. |
ferventcoder
changed the title
|
@jrkd I see that. CLAHub didn't catch it though. You are good. Thanks! By the way |
|
Fixed up and merged into stable at e428c85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(maint)
Issue here is the minor version is always required to be > 2, so now that we're at windows 10.0.x /all is not being added, even though this logic really only wanted to make sure the version was >= 6.2
This commit adds a check to see if the version is greater than 6 entirely, if not, only then does it check if its version 6 and at least minor ver. 6.2.
How this issue affects the functionality: Not calling /all as part of dism meant that dependencies for windows features are never installed as part of the installation.
Closes #897