Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to target version 3.13.3 of NUnit #2880

Closed
AdmiringWorm opened this issue Nov 2, 2022 · 1 comment · Fixed by #2883
Closed

Upgrade to target version 3.13.3 of NUnit #2880

AdmiringWorm opened this issue Nov 2, 2022 · 1 comment · Fixed by #2883
Labels
5 - Released NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Milestone
2.0.0

Comments

@AdmiringWorm
Copy link
Member

Is Your Feature Request Related To A Problem? Please describe.

N/A

Describe The Solution. Why is it needed?

As part of the uplift to .NET 4.8 in #2738 we should also update the testing framework to the latest version of NUnit to take advantage of some of the features that was introduced in this major version.

Additional Context.

To uplift the library to NUnit v3 it will require removing the dependency on TinySpec, which should be fine as it only copies a file to our project for us to use.

Related Issues
@AdmiringWorm AdmiringWorm added this to the 2.0.0 milestone Nov 2, 2022
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Nov 2, 2022
@AdmiringWorm
(chocolatey#2880) Update NUnit dependencies to v3
b96d1eb 
This commit updates any references to use NUnit v3 as well
as updating the code we have in testing to the equivalent in
the new version of NUnit.
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Nov 11, 2022
Closed
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Nov 16, 2022
@AdmiringWorm
(chocolatey#2880) Update NUnit dependencies to v3
1b330e3 
This commit updates any references to use NUnit v3 as well
as updating the code we have in testing to the equivalent in
the new version of NUnit.
@AdmiringWorm AdmiringWorm mentioned this issue Nov 16, 2022
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Nov 16, 2022
@AdmiringWorm
(chocolatey#2880) Update NUnit dependencies to v3
3f3531f 
This commit updates any references to use NUnit v3 as well
as updating the code we have in testing to the equivalent in
the new version of NUnit.
gep13 pushed a commit to AdmiringWorm/choco that referenced this issue Nov 17, 2022
@AdmiringWorm @gep13
(chocolatey#2880) Update NUnit dependencies to v3
7bafa88 
This commit updates any references to use NUnit v3 as well
as updating the code we have in testing to the equivalent in
the new version of NUnit.
gep13 added a commit to AdmiringWorm/choco that referenced this issue Nov 17, 2022
@gep13
(chocolatey#2880) Add more exclusions for what is ILMerge
42220ff 
As we have added new dependencies to the build, i.e. we have changed t
NUnit v3 which includes some additional assemblies in the output
folder, we need to ensure that these are not included in what is being
ILMerge'd into the choco.exe.
gep13 added a commit that referenced this issue Nov 17, 2022
@gep13
Merge pull request #2883 from AdmiringWorm/upgrade-nunit-to-3.x
924a785 
(#2880) Update NUnit dependencies to v3
@gep13 gep13 changed the title Uplift Test Libraries to use NUnit v3 Upgrade to target version 3.13.3 of NUnit Jan 24, 2023
@gep13 gep13 added 4 - Done NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. and removed 0 - _Triaging Task labels Jan 24, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(#2880) Update NUnit dependencies to v3 AdmiringWorm/choco
3 participants
@gep13 @AdmiringWorm @choco-bot