New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Should to FluentAssertions #2893

Closed

TheCakeIsNaOH opened this issue Nov 9, 2022 · 4 comments · Fixed by #2908

Assignees

Labels

5 - Released NO RELEASE NOTES Task Tests

Milestone

Member

TheCakeIsNaOH commented Nov 9, 2022

Is Your Feature Request Related To A Problem? Please describe.

Currently, the integration tests library uses the Should nuget package for assertions in tests.
This package is only build for .Net framework, and not newer Dotnet versions.
It appears to be abandoned, with the last release to nuget.org pushed what is getting close to a decade ago, and old un-merged pulled requests on the source repository:
erichexter/Should#19

It does not have a complete complement of assertions, there are other libraries with more.

Describe The Solution. Why is it needed?

So it would be good to switch to another library that is built for .Net Standard, so it can be used with .Net 4.8 and the forthcoming dotnet build.

There are two popular options for assertion libraries that I am aware of:
https://www.nuget.org/packages/FluentAssertions
And
https://www.nuget.org/packages/Shouldly

As far as I am aware, they should be both good options, and it is up to whatever team members like better, or which is already in use elsewhere.

Additional Context.

N/A

Related Issues

Issue Upgrade to target version 4.8 of the .NET Framework #2738

TheCakeIsNaOH added 0 - _Triaging Task Tests labels

Member

gep13 commented Nov 11, 2022

I had a quick chat with @AdmiringWorm about this today, and we are thinking that FluentAssertions might be the way to go.

@TheCakeIsNaOH thoughts?

Member Author

TheCakeIsNaOH commented Nov 11, 2022

@gep13 sounds good to me.

One additional thing I forgot to mention was that TinySpec.NUnit takes a dependency on Should, but the TinySpec package is planned to be removed as a part of #2880, so it should not be an issue for much longer.

This comment was marked as off-topic.

Sign in to view

gep13 changed the title ~~Migrate from Should to another assertions library.~~ Migrate from Should to FluentAssertions

TheCakeIsNaOH added 0 - Backlog and removed 0 - _Triaging labels

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch from Should to FluentAssertions

6d578dc

This switches chocolatey.tests and chocolatey.tests.integration
to use FluentAssertions instead of Should. This is because Should
is no longer actively maintained, so it is time to replace it.

As per the FluentAssertions api, various calls needed to be adjusted,
mostly in the pattern Shouldxxxx() to Should().xxxx()

TheCakeIsNaOH added 3 - Review 2 - Working and removed 0 - Backlog 3 - Review labels

TheCakeIsNaOH mentioned this issue

(#2893) Switch from Should to FluentAssertions #2908

Merged

9 tasks

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch Unit and Integration tests to langVersion 7.3

bf66eca

This is to allow Visual Studio 2017 to build the project.
Otherwise, code in the FluentAssertions library will cause errors when build with VS2017.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch from Should to FluentAssertions

cd81eed

This switches chocolatey.tests and chocolatey.tests.integration
to use FluentAssertions instead of Should. This is because Should
is no longer actively maintained, so it is time to replace it.

As per the FluentAssertions api, various calls needed to be adjusted,
mostly in the pattern Shouldxxxx() to Should().xxxx()

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch Unit and Integration tests to langVersion 7.3

6413f70

This is to allow Visual Studio 2017 to build the project.
Otherwise, code in the FluentAssertions library will cause errors when build with VS2017.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch from Should to FluentAssertions

f4caded

This switches chocolatey.tests and chocolatey.tests.integration
to use FluentAssertions instead of Should. This is because Should
is no longer actively maintained, so it is time to replace it.

As per the FluentAssertions api, various calls needed to be adjusted,
mostly in the pattern Shouldxxxx() to Should().xxxx()

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch Unit and Integration tests to langVersion 7.3

8e7fd88

This is to allow Visual Studio 2017 to build the project.
Otherwise, code in the FluentAssertions library will cause errors when build with VS2017.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch from Should to FluentAssertions

4bbbf8e

This switches chocolatey.tests and chocolatey.tests.integration
to use FluentAssertions instead of Should. This is because Should
is no longer actively maintained, so it is time to replace it.

As per the FluentAssertions api, various calls needed to be adjusted,
mostly in the pattern Shouldxxxx() to Should().xxxx()

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch Unit and Integration tests to langVersion 7.3

This is to allow Visual Studio 2017 to build the project.
Otherwise, code in the FluentAssertions library will cause errors when build with VS2017.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch from Should to FluentAssertions

4d843b8

This switches chocolatey.tests and chocolatey.tests.integration
to use FluentAssertions instead of Should. This is because Should
is no longer actively maintained, so it is time to replace it.

Only the package and dependencies are switched. The code changes
be in the next commit.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update references and syntax to FluentAssertions

1b9a32a

As per the FluentAssertions api, various calls needed to be adjusted,
mostly in the pattern Shouldxxxx() to Should().xxxx()

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch Unit and Integration tests to langVersion 7.3

af4ba7b

This is to allow Visual Studio 2017 to build the project.
Otherwise, code in the FluentAssertions library will cause errors when build with VS2017.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch from Should to FluentAssertions

40bb5e7

This switches chocolatey.tests and chocolatey.tests.integration
to use FluentAssertions instead of Should. This is because Should
is no longer actively maintained, so it is time to replace it.

Only the package and dependencies are switched. The code changes
be in the next commit.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update references and syntax to FluentAssertions

017a7ab

As per the FluentAssertions api, various calls needed to be adjusted,
mostly in the pattern Shouldxxxx() to Should().xxxx()

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch from Should to FluentAssertions

5958e1e

This switches chocolatey.tests and chocolatey.tests.integration
to use FluentAssertions instead of Should. This is because Should
is no longer actively maintained, so it is time to replace it.

Only the package and dependencies are switched. The code changes
be in the next commit.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update references and syntax to FluentAssertions

40b7931

As per the FluentAssertions api, various calls needed to be adjusted,
mostly in the pattern Shouldxxxx() to Should().xxxx()

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch Unit and Integration tests to langVersion 7.3

d0767a4

This is to allow Visual Studio 2017 to build the project.
Otherwise, code in the FluentAssertions library will cause errors when build with VS2017.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update tests to use to FluentAssertions style

43fa9d8

This updates tests to use new ways of writing assertions that are available in
FluentAssertions but where not in Should

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch from Should to FluentAssertions

25e97f6

This switches chocolatey.tests and chocolatey.tests.integration
to use FluentAssertions instead of Should. This is because Should
is no longer actively maintained, so it is time to replace it.

The Fluent Assertions Analyzers are also added in this commit.

Only the package and dependencies are switched. The code
changes be in the next commit.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update references and syntax to FluentAssertions

42654c0

As per the FluentAssertions api, various calls needed to be adjusted,
mostly in the pattern Shouldxxxx() to Should().xxxx()

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch Unit and Integration tests to langVersion 7.3

b53b46f

This is to allow Visual Studio 2017 to build the project.
Otherwise, code in the FluentAssertions library will cause errors when build with VS2017.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update tests to use to FluentAssertions style

dc382f7

This updates tests to use new ways of writing assertions that are available in
FluentAssertions but where not in Should

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update tests to use to FluentAssertions style

1c1b580

This updates tests to use new ways of writing assertions that are available in
FluentAssertions but where not in Should

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update tests to use to FluentAssertions style

3cf3150

This updates tests to use new ways of writing assertions that are available in
FluentAssertions but where not in Should

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch from Should to FluentAssertions

9ec58e3

This switches chocolatey.tests and chocolatey.tests.integration
to use FluentAssertions instead of Should. This is because Should
is no longer actively maintained, so it is time to replace it.

The Fluent Assertions Analyzers are also added in this commit.

Only the package and dependencies are switched. The code
changes be in the next commit.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update references and syntax to FluentAssertions

9da16ba

As per the FluentAssertions api, various calls needed to be adjusted,
mostly in the pattern Shouldxxxx() to Should().xxxx()

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch Unit and Integration tests to langVersion 7.3

6a02b33

This is to allow Visual Studio 2017 to build the project.
Otherwise, code in the FluentAssertions library will cause errors when build with VS2017.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update tests to use to FluentAssertions style

525fc47

This updates tests to use new ways of writing assertions that are available in
FluentAssertions but where not in Should

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update tests to use to FluentAssertions style

0d18d5a

This updates tests to use new ways of writing assertions that are available in
FluentAssertions but where not in Should

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update tests to use to FluentAssertions style

1a35a27

This updates tests to use new ways of writing assertions that are available in
FluentAssertions but where not in Should

AdmiringWorm pushed a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch from Should to FluentAssertions

643df4f

This switches chocolatey.tests and chocolatey.tests.integration
to use FluentAssertions instead of Should. This is because Should
is no longer actively maintained, so it is time to replace it.

The Fluent Assertions Analyzers are also added in this commit.

Only the package and dependencies are switched. The code
changes be in the next commit.

AdmiringWorm pushed a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update references and syntax to FluentAssertions

5b2b774

As per the FluentAssertions api, various calls needed to be adjusted,
mostly in the pattern Shouldxxxx() to Should().xxxx()

AdmiringWorm pushed a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch Unit and Integration tests to langVersion 7.3

6ba9e15

This is to allow Visual Studio 2017 to build the project.
Otherwise, code in the FluentAssertions library will cause errors when build with VS2017.

AdmiringWorm pushed a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update tests to use to FluentAssertions style

7b3f795

This updates tests to use new ways of writing assertions that are available in
FluentAssertions but where not in Should

AdmiringWorm pushed a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch from Should to FluentAssertions

3bdeb93

This switches chocolatey.tests and chocolatey.tests.integration
to use FluentAssertions instead of Should. This is because Should
is no longer actively maintained, so it is time to replace it.

The Fluent Assertions Analyzers are also added in this commit.

Only the package and dependencies are switched. The code
changes be in the next commit.

AdmiringWorm pushed a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update references and syntax to FluentAssertions

9d5b05c

As per the FluentAssertions api, various calls needed to be adjusted,
mostly in the pattern Shouldxxxx() to Should().xxxx()

AdmiringWorm pushed a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Switch Unit and Integration tests to langVersion 7.3

51efab5

This is to allow Visual Studio 2017 to build the project.
Otherwise, code in the FluentAssertions library will cause errors when build with VS2017.

AdmiringWorm pushed a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2893) Update tests to use to FluentAssertions style

c853166

This updates tests to use new ways of writing assertions that are available in
FluentAssertions but where not in Should

AdmiringWorm closed this as completed in #2908

AdmiringWorm added 4 - Done NO RELEASE NOTES and removed 2 - Working labels

AdmiringWorm added this to the 2.1.0 milestone

AdmiringWorm added a commit that referenced this issue


          Merge pull request #2908 from TheCakeIsNaOH/gh2893-fluent-assertions

5961b94

(#2893) Switch from Should to FluentAssertions

gep13 added 5 - Released and removed 4 - Done labels

choco-bot commented Jun 29, 2023

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment