(#2880) Update NUnit dependencies to v3 #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: PROJ-357 Uplift NUnit |
AdmiringWorm
force-pushed
the
upgrade-nunit-to-3.x
branch
from
b96d1eb to
1d7190e
Compare
AdmiringWorm
force-pushed
the
upgrade-nunit-to-3.x
branch
from
1d7190e to
e672b0b
Compare
This commit updates any references to use NUnit v3 as well as updating the code we have in testing to the equivalent in the new version of NUnit.
This commit updates the tests that tests different commands and any tests that are considered integration tests to add the correct category for these tests.
This commit updates the attribute ConcernFor to inherit from the NUnit CategoryAttribute so usage of this attribute will categorize the tests that makes use of it with the appropriate category.
This commit updates a test that verifies that a test that reports an exception is running under the English culture. This is done so the test won't fail when it is running on non-english cultures just because the messaging would be different.
This commit updates the assertions made to detect whether a file or directory exists or not to instead of assertion on true/false it instead asserts directly using NUnit v3 assertion classes. This is done so if the test fails there will be more information outputted of the failure than just telling whether something was true or false.
gep13
force-pushed
the
upgrade-nunit-to-3.x
branch
from
e672b0b to
0368d37
Compare
|
@AdmiringWorm the failing builds here are due to a new feature that was added into Chocolatey.Cake.Recipe. That shouldn't stop this work getting merged in though, since there is some follow up work that needs to be done after this merged, so assuming that the Windows builds succeeds, let's get this merged in, and we can ship a new version of Chocolatey.Cake.Recipe to address the failing builds on Posix. |
As we have added new dependencies to the build, i.e. we have changed t NUnit v3 which includes some additional assemblies in the output folder, we need to ensure that these are not included in what is being ILMerge'd into the choco.exe.
|
@AdmiringWorm thank you for taking the time to get this updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This pull request updates any references to use NUnit v3 as well
as updating the code we have in testing to the equivalent in
the new version of NUnit.
Additionally, it makes some maintenance commits to helping with working on the codebase and unit tests by making several tests be categorized so they can be more easily detected in the Visual Studio test runner.
Motivation and Context
Modernizing
Testing
Change Types Made
Related Issue
Fixes #2880
Change Checklist