New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshotting of files and config transform has been enabled on non-Windows systems #2450

Closed

TheCakeIsNaOH opened this issue Nov 13, 2021 · 0 comments · Fixed by #2451

Assignees

Labels

5 - Released Improvement

Milestone

Member

TheCakeIsNaOH commented Nov 13, 2021

It would be good to run the post-install files snapshot and the post-install config transform on non-Windows platforms.

Both seem to work fine, but they are currently skipped.

In the future, the files snapshot may also snapshot locations that do not exist on non-Windows (#530), but I think those location(s) should be individually skipped instead the entire snapshot being skipped.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform and FilesSnapshot on non-Win…

2a013ab

…dows

This runs configTransformService and capture_package_files on
non-Windows platforms. Both appear to be fully functional, so there is
no reason not to run them.

They were added to non-Windows side of the if/else instead of being
moved from the Windows side so as to not screw up the functionality of
create_ignore_files_for_executables.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform and FilesSnapshot on non-Win…

19ab672

…dows

This runs configTransformService and capture_package_files on
non-Windows platforms. Both appear to be fully functional, so there is
no reason not to run them.

They were added to non-Windows side of the if/else instead of being
moved from the Windows side so as to not screw up the functionality of
create_ignore_files_for_executables.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform tests on non-Windows

066bb80

Re-enables the integration tests that validate the config transform
service on non-Windows platforms. These can be enabled now that the
config transform service runs on non-Windows platforms.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform tests on non-Windows

25bc038

Re-enables the integration tests that validate the config transform
service on non-Windows platforms. These can be enabled now that the
config transform service runs on non-Windows platforms.

TheCakeIsNaOH mentioned this issue

(#2450) Enable configTransform and FilesSnapshot on non-Windows #2451

Merged

7 tasks

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform and FilesSnapshot on non-Win…

303b653

…dows

This runs configTransformService and capture_package_files on
non-Windows platforms. Both appear to be fully functional, so there is
no reason not to run them.

They were added to non-Windows side of the if/else instead of being
moved from the Windows side so as to not screw up the functionality of
create_ignore_files_for_executables.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform tests on non-Windows

4c32047

Re-enables the integration tests that validate the config transform
service on non-Windows platforms. These can be enabled now that the
config transform service runs on non-Windows platforms.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform and FilesSnapshot on non-Win…

728102c

…dows

This runs configTransformService and capture_package_files on
non-Windows platforms. Both appear to be fully functional, so there is
no reason not to run them.

They were added to non-Windows side of the if/else instead of being
moved from the Windows side so as to not screw up the functionality of
create_ignore_files_for_executables.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform tests on non-Windows

e874173

Re-enables the integration tests that validate the config transform
service on non-Windows platforms. These can be enabled now that the
config transform service runs on non-Windows platforms.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform and FilesSnapshot on non-Win…

bc9a144

…dows

This runs configTransformService and capture_package_files on
non-Windows platforms. Both appear to be fully functional, so there is
no reason not to run them.

They were added to non-Windows side of the if/else instead of being
moved from the Windows side so as to not screw up the functionality of
create_ignore_files_for_executables.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform tests on non-Windows

e66c781

Re-enables the integration tests that validate the config transform
service on non-Windows platforms. These can be enabled now that the
config transform service runs on non-Windows platforms.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform and FilesSnapshot on non-Win…

…dows

This runs configTransformService and capture_package_files on
non-Windows platforms. Both appear to be fully functional, so there is
no reason not to run them.

They were added to non-Windows side of the if/else instead of being
moved from the Windows side so as to not screw up the functionality of
create_ignore_files_for_executables.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform tests on non-Windows

1b93e99

Re-enables the integration tests that validate the config transform
service on non-Windows platforms. These can be enabled now that the
config transform service runs on non-Windows platforms.

gep13 added this to the 0.12.0 milestone

gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable functions on non-Windows systems

f02a2e6

This runs configTransformService and capture_package_files on
non-Windows platforms. Both appear to be fully functional, so there is
no reason not to run them.

They were added to non-Windows side of the if/else instead of being
moved from the Windows side so as to not screw up the functionality of
create_ignore_files_for_executables.

gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue


          (chocolatey#2450) Enable configTransform tests on non-Windows

a256c27

Re-enables the integration tests that validate the config transform
service on non-Windows platforms. These can be enabled now that the
config transform service runs on non-Windows platforms.

gep13 closed this as completed in #2451

gep13 added a commit that referenced this issue


          Merge pull request #2451 from TheCakeIsNaOH/snapshot-transform

f0040ca

(#2450) Enable configTransform and FilesSnapshot on non-Windows

gep13 assigned TheCakeIsNaOH

gep13 added 4 - Done Improvement labels

gep13 changed the title ~~Enable files snapshot and config transform on non-Windows~~ Snapshotting of files and config transform has been enabled on non-Windows systems

gep13 added a commit that referenced this issue


          Merge branch 'release/0.12.0'

b6cb760

* release/0.12.0: (102 commits)
  (maint) Add generation of template command
  (#2522) Update documentation
  (maint) Remove unnecessary whitespace
  (#2522) Remove deprecated ScriptsCheckLastExitCode
  (maint) Fix spelling mistake
  (version) 0.12.0-beta
  (#2518) Add tab completion for template command
  (#2481) Warn about unuspported packages on non-Windows
  (#357) Add information about when command added
  (#449) Add information about when command added
  (#499) Add specs for template service list noop
  (#499) Add specs for template command
  (#449) Add template command
  (#449) Template service rename noop to generate_noop
  (#2434) Correct casing of filename in changed files tests
  (#2434) Enable more scenarios, skip only shim and powershell facts
  (#2450) Enable configTransform tests on non-Windows
  (#2450) Enable functions on non-Windows systems
  (maint) Corrected casing of PowerShell
  (#2510) Exclude uninstalling with locked file on non-windows
  ...

gep13 added 5 - Released and removed 4 - Done labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment