(#2450) Enable configTransform and FilesSnapshot on non-Windows #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm getting a failure in That is why this is a draft for the moment. |
TheCakeIsNaOH
force-pushed
the
snapshot-transform
branch
from
25bc038 to
4c32047
Compare
TheCakeIsNaOH
force-pushed
the
snapshot-transform
branch
2 times, most recently
from
e874173 to
e66c781
Compare
|
Rebased onto #2511, the tests are working now. |
6 tasks
TheCakeIsNaOH
force-pushed
the
snapshot-transform
branch
from
e66c781 to
1b93e99
Compare
This runs configTransformService and capture_package_files on non-Windows platforms. Both appear to be fully functional, so there is no reason not to run them. They were added to non-Windows side of the if/else instead of being moved from the Windows side so as to not screw up the functionality of create_ignore_files_for_executables.
Re-enables the integration tests that validate the config transform service on non-Windows platforms. These can be enabled now that the config transform service runs on non-Windows platforms.
gep13
force-pushed
the
snapshot-transform
branch
from
1b93e99 to
a256c27
Compare
|
@TheCakeIsNaOH thanks for getting this added, this is a great addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This runs configTransformService and capture_package_files on
non-Windows platforms. Both appear to be fully functional, so there is
no reason not to run them. They were added to non-Windows side of the if/else instead of being
moved from the Windows side so as to not screw up the functionality of
create_ignore_files_for_executables.
Also re-enables the integration tests that validate the config transform
service on non-Windows platforms. These can be enabled now that the
config transform service runs on non-Windows platforms.
Motivation and Context
It would be good to get these two features working on non-Windows, as they both should be working.
It also lets more integration tests work on non-Windows
Testing
mono choco.exe install --allow-unofficial msi.template zip.template --verbose --debug.chocolateydirectory.The
configTransformis tested in thewhen_installing_a_package_with_config_transformstest which is now enabled, along with the upgrade tests which pass.Change Types Made
Related Issue
Fixes #2450
Depends on #2511
Change Checklist