-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chocolatey packaging script (chocolateyBeforeModify.ps1) incorrectly running on non-Windows platforms #2510
Comments
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/choco
that referenced
this issue
Jan 6, 2022
This sets the beforemodify script to only run on windows platforms. The powershell scripts do not work on non-windows platforms, so they should not be run.
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/choco
that referenced
this issue
Jan 6, 2022
…dows This put a check on the powershell uninstall script, shimgen uninstall, autoUninstaller and shutdown /a calls during uninstall. They will now only run on windows. None of these services work on non-windows, so they should not be run
7 tasks
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/choco
that referenced
this issue
Jan 6, 2022
This skips the when_uninstalling_a_package_with_an_exclusively_locked_file test on non-windows systems. This test previously worked because the install was failing due to the beforemodify script, but now that the script run has been disabled, this test fails on non-windows platforms.
gep13
pushed a commit
to TheCakeIsNaOH/choco
that referenced
this issue
Jan 10, 2022
This sets the beforemodify script to only run on windows platforms. The powershell scripts do not work on non-windows platforms, so they should not be run.
gep13
pushed a commit
to TheCakeIsNaOH/choco
that referenced
this issue
Jan 10, 2022
…dows This put a check on the powershell uninstall script, shimgen uninstall, autoUninstaller and shutdown /a calls during uninstall. They will now only run on windows. None of these services work on non-windows, so they should not be run
gep13
pushed a commit
to TheCakeIsNaOH/choco
that referenced
this issue
Jan 10, 2022
This skips the when_uninstalling_a_package_with_an_exclusively_locked_file test on non-windows systems. This test previously worked because the install was failing due to the beforemodify script, but now that the script run has been disabled, this test fails on non-windows platforms.
gep13
added a commit
that referenced
this issue
Jan 10, 2022
(#2510) Stop Beforemodify scripts from running on non-windows
gep13
changed the title
Beforemodify scripts still running on non-windows platforms
Chocolatey packaging script (chocolateyBeforeModify.ps1) incorrectly running on non-windows platforms
Jan 17, 2022
gep13
changed the title
Chocolatey packaging script (chocolateyBeforeModify.ps1) incorrectly running on non-windows platforms
Chocolatey packaging script (chocolateyBeforeModify.ps1) incorrectly running on non-Windows platforms
Jan 18, 2022
gep13
added a commit
that referenced
this issue
Jan 18, 2022
* release/0.12.0: (102 commits) (maint) Add generation of template command (#2522) Update documentation (maint) Remove unnecessary whitespace (#2522) Remove deprecated ScriptsCheckLastExitCode (maint) Fix spelling mistake (version) 0.12.0-beta (#2518) Add tab completion for template command (#2481) Warn about unuspported packages on non-Windows (#357) Add information about when command added (#449) Add information about when command added (#499) Add specs for template service list noop (#499) Add specs for template command (#449) Add template command (#449) Template service rename noop to generate_noop (#2434) Correct casing of filename in changed files tests (#2434) Enable more scenarios, skip only shim and powershell facts (#2450) Enable configTransform tests on non-Windows (#2450) Enable functions on non-Windows systems (maint) Corrected casing of PowerShell (#2510) Exclude uninstalling with locked file on non-windows ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What You Are Seeing?
beforemodify scripts are still running during upgrades and uninstall on non-windows platforms.
Also, during uninstall, the automatic uninstaller and shimgen services are still running, while on the install/upgrade phase they are not running.
What is Expected?
The before modify scripts should not attempt to run on non-windows platforms.
How Did You Get This To Happen? (Steps to Reproduce)
upgradepackage
installchoco install --version=1.0.0 -s ./context upgradepackage
choco upgrade -s ./context upgradepackage
(or uninstall)See this comment as well: #2434 (comment)
Output Log
Full Log Output
The text was updated successfully, but these errors were encountered: