When the C_JALR instruction convert to bin format, we meet error. The rs1 should not be X0. #826

GZYyyyy · 2021-09-30T06:42:51Z

riscv-dv/src/isa/riscv_compressed_instr.sv line 317:
C_JALR:
binary = $sformatf("%4h", {get_func3(), 1'b1, 10'b0, get_c_opcode()});
the rs1 is X0.
However, according to riscv-spec-20191213.
the rs1 should not be X0，it is illegal!

Signed-off-by: Henrik Fegran <[email protected]>

Fix for issue #826, illegal rs1 in C_JALR

Update code from upstream repository https://github.com/google/riscv- dv to revision d7c50c1eb9abe85bd6673878fe2e98489cf5f07e * Fix `update_src_regs` for ZBB (Greg Chadwick) * Sample bitmanip instruction coverage (Greg Chadwick) * Fix for issue chipsalliance/riscv-dv#826, illegal rs1 in C_JALR (Henrik Fegran) Signed-off-by: Greg Chadwick <[email protected]>

silabs-hfegran added a commit to silabs-hfegran/riscv-dv that referenced this issue Jul 25, 2022

Fix for issue chipsalliance#826, illegal rs1 in C_JALR

88dae63

Signed-off-by: Henrik Fegran <[email protected]>

pradheepkaliraj added a commit that referenced this issue Nov 7, 2022

Merge pull request #875 from silabs-hfegran/dev_hf_cjalr_rs1_fix

1246c39

Fix for issue #826, illegal rs1 in C_JALR

GregAC mentioned this issue Nov 13, 2022

Update google_riscv-dv to google/riscv-dv@d7c50c1 lowRISC/ibex#1930

Merged

puneet added a commit to puneet/riscv-dv that referenced this issue Oct 9, 2023

[euvm] Fix for issue chipsalliance#826, illegal rs1 in C_JALR

49cde34

puneet added a commit to coverify/riscv-dv that referenced this issue Jan 9, 2024

[euvm] Fix for issue chipsalliance#826, illegal rs1 in C_JALR

a01579a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When the C_JALR instruction convert to bin format, we meet error. The rs1 should not be X0. #826

When the C_JALR instruction convert to bin format, we meet error. The rs1 should not be X0. #826

GZYyyyy commented Sep 30, 2021

When the C_JALR instruction convert to bin format, we meet error. The rs1 should not be X0. #826

When the C_JALR instruction convert to bin format, we meet error. The rs1 should not be X0. #826

Comments

GZYyyyy commented Sep 30, 2021