Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make isView safe outside of Builder context (backport #4228) #4230

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 28, 2024

Contemplating views in naming (#4222) exposed a longstanding bug that I patched out recently in #4147. Basically isView does not work outside of Builder contexts. Now it is safe.

We do have lots of tests for things like literals outside of Builder contexts, but they didn't trigger this because ViewParent is a lazy val and thus if any Chisel elaboration has occurred on the same thread, then the problem doesn't manifest. Thus this "test" looks very strange, but by virtue of defining a literal assigned to a val first thing in a ScalaTest spec, it ensures no Chisel elaboration has run before when this line executes, and the naming plugin + #4222 ensures that this value is checked if it's a view.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4228 done by [Mergify](https://mergify.com).

@mergify mergify bot added the Backport Automated backport, please consider for minor release label Jun 28, 2024
@github-actions github-actions bot added the Bugfix Fixes a bug, will be included in release notes label Jun 28, 2024
@chiselbot chiselbot merged commit 7687a30 into 5.x Jun 28, 2024
17 checks passed
@chiselbot chiselbot deleted the mergify/bp/5.x/pr-4228 branch June 28, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants