Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name the targets of identity views #4222

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

jackkoenig
Copy link
Contributor

I'm calling this a bugfix because it fixes an issue exacerbated by #4198, but it's also sort of a feature. The crux of the motivation for this change is visible in the change to VecSpec. Basically, if the user returns a view in lieu of the underlying target Data, the actual Data does not currently get named. This PR fixes it by having identity views forward their naming on to the underlying target. This PR is made much more important by #4198 because this now comes up quite a bit in user code, VecSpec showing an example.

Future work is handling non-identity views because it is reasonable to forward naming in those cases as well, but perhaps with additional prefixing based on the "local" name of the target within the view Aggregate.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)
  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Jun 27, 2024
@jackkoenig jackkoenig added this to the 6.x milestone Jun 27, 2024
@jackkoenig jackkoenig enabled auto-merge (squash) June 27, 2024 18:30
@jackkoenig jackkoenig merged commit 530155d into main Jun 27, 2024
15 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/name-targets-of-identity-views branch June 27, 2024 18:45
@mergify mergify bot added the Backported This PR has been backported label Jun 27, 2024
mergify bot pushed a commit that referenced this pull request Jun 27, 2024
chiselbot pushed a commit that referenced this pull request Jun 27, 2024
(cherry picked from commit 530155d)

Co-authored-by: Jack Koenig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants