Name the targets of identity views #4222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm calling this a bugfix because it fixes an issue exacerbated by #4198, but it's also sort of a feature. The crux of the motivation for this change is visible in the change to
VecSpec
. Basically, if the user returns a view in lieu of the underlying target Data, the actual Data does not currently get named. This PR fixes it by having identity views forward their naming on to the underlying target. This PR is made much more important by #4198 because this now comes up quite a bit in user code,VecSpec
showing an example.Future work is handling non-identity views because it is reasonable to forward naming in those cases as well, but perhaps with additional prefixing based on the "local" name of the target within the view Aggregate.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.