Suppress exception throwing in Data.toString #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
commented
Jun 6, 2024
Comment on lines
+92
to
106
| 3.U.toString should be("UInt<2>(3)") | ||
| 3.U(5.W).toString should be("UInt<5>(3)") | ||
| -1.S.toString should be("SInt<1>(-1)") | ||
| false.B.toString should be("Bool(false)") | ||
| true.B.toString should be("Bool(true)") | ||
| Vec(3, UInt(4.W)).toString should be("UInt<4>[3]") | ||
| EnumTest.sNone.toString should be("EnumTest(0=sNone)") | ||
| EnumTest.sTwo.toString should be("EnumTest(2=sTwo)") | ||
| EnumTest(1.U).toString should be("EnumTest(1=sOne)") | ||
| (new BundleTest).Lit(_.a -> 2.U, _.b -> false.B).toString should be("BundleTest(a=UInt<8>(2), b=Bool(false))") | ||
| (new PartialBundleTest).Lit().toString should be( | ||
| "PartialBundleTest(a=UInt<8>(DontCare), b=Bool(DontCare), c=SInt<8>(DontCare), f=EnumTest(DontCare))" | ||
| ) | ||
| DontCare.toString should be("DontCare()") | ||
| } |
There was a problem hiding this comment.
The "test" in this PR is that all of these should (and now do) work outside of a Builder context.
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
(cherry picked from commit 139be37)
14 tasks
chiselbot
pushed a commit
that referenced
this pull request
Jun 7, 2024
(cherry picked from commit 139be37) Co-authored-by: Jack Koenig <[email protected]>
14 tasks
This was referenced Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
This makes
.toStringbehavior better outside of Chisel elaboration contexts.Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.