removed unused config keys #6781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArvinthC3000 <[email protected]>
|
✔️ Deploy Preview for chef-automate ready! 🔨 Explore the source changes: e61e15d 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6228de86aa88f500091a7d54 😎 Browse the preview: https://deploy-preview-6781--chef-automate.netlify.app/automate/cli_chef_automate |
ArvinthC3000
requested review from
kalroy,
karunesh-tech,
punitmundra,
sandhi18,
shanmugapriya-tr,
jayvikramsharma1 and
FaizanSRE
|
Kudos, SonarCloud Quality Gate passed!
|
punitmundra
approved these changes
Mar 9, 2022
kalroy
added a commit
that referenced
this pull request
Mar 18, 2022
* Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Added few debug logs Signed-off-by: shanmugapriya-tr <[email protected]> * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changed Service names to constants Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored code Signed-off-by: shanmugapriya-tr <[email protected]> * Changes to resolve the issue with service restart on patch Signed-off-by: sandhi <[email protected]> * Update components/automate-deployment/pkg/server/server.go Co-authored-by: Kallol Roy <[email protected]> * Changed array to map Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Changed Service names to constants Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored code Signed-off-by: shanmugapriya-tr <[email protected]> * Changes to resolve the issue with service restart on patch Signed-off-by: sandhi <[email protected]> * Update components/automate-deployment/pkg/server/server.go Co-authored-by: Kallol Roy <[email protected]> * Changed array to map Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changed Service names to constants Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored code Signed-off-by: shanmugapriya-tr <[email protected]> * Changes to resolve the issue with service restart on patch Signed-off-by: sandhi <[email protected]> * Update components/automate-deployment/pkg/server/server.go Co-authored-by: Kallol Roy <[email protected]> * Changed array to map Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * added automateHA mount path (#6739) * added automateHA mount path Signed-off-by: ArvinthC3000 <[email protected]> * added automateHA mount path - dynamic path test Signed-off-by: ArvinthC3000 <[email protected]> * Added backup_mount variable * backup_mount path from variables_common added(test commit) Signed-off-by: ArvinthC3000 <[email protected]> * reverting changes Signed-off-by: ArvinthC3000 <[email protected]> * Adding dynamic mount path to automate backup folder creation Signed-off-by: ArvinthC3000 <[email protected]> * Static backup mount path * trigger changes Signed-off-by: ArvinthC3000 <[email protected]> * removing dead code Signed-off-by: ArvinthC3000 <[email protected]> * Rename HA_architecture_reference.md to ha_architecture_reference.md * removed unused config keys (#6781) Signed-off-by: ArvinthC3000 <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changed Service names to constants Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored code Signed-off-by: shanmugapriya-tr <[email protected]> * Changes to resolve the issue with service restart on patch Signed-off-by: sandhi <[email protected]> * Update components/automate-deployment/pkg/server/server.go Co-authored-by: Kallol Roy <[email protected]> * Changed array to map Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Fixing License Scout (#6782) * Fixing License Scout Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Fixing License Scout for msgp Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Cli milestone part-1 (#6762) * added Todo(milestone) for the servers Signed-off-by: Kallol Roy <[email protected]> * added more Todo(milestone) for the servers Signed-off-by: Kallol Roy <[email protected]> * adding to-dos Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * upgrading to minor/patch version (#6621) * upgrade to minor\patch Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * supporting sem version Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * considering version flag in upgrade Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * compute min current version for airgap bundle create- second pr (#6665) * adding min current version to manifest in bundle creation Signed-off-by: Rick Marry <[email protected]> * adding min current version to manifest in bundle creation Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> Co-authored-by: dmaddu <[email protected]> * major upgrade with checklist (#6660) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * fixing buildkite (#6674) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * airgap bundle upgrade (#6682) * airgap upgrade Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * upgrade status for airgap Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * upgrade status for airgap instance Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * addressing review comments Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Show Major Version Release Banner on UI (#6663) * banner-manual-upgrade changes Signed-off-by: Venkatesh-rengasamy <[email protected]> * add banner logo Signed-off-by: Venkatesh-rengasamy <[email protected]> * updating error messages to be shown to end user (#6714) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * ignoring semgrep rule Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * fixing pipeline issue (#6717) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * supporting external versions file (#6748) * supporting external versions file Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * fixing pipeline Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * showing pre post Checklist for milestone release (#6706) * postchecklist Signed-off-by: shaik80 <[email protected]> * json file Signed-off-by: shaik80 <[email protected]> * readPostCheckList Signed-off-by: shaik80 <[email protected]> * read json file for postchecklist Signed-off-by: shaik80 <[email protected]> * upgrade to major and and print postchecklist steps Signed-off-by: shaik80 <[email protected]> * test cases and basic changes Signed-off-by: shaik80 <[email protected]> * dynamic version Signed-off-by: shaik80 <[email protected]> * old manifests url Signed-off-by: shaik80 <[email protected]> * error handling in upgrade status if we don't hav compatible version Signed-off-by: shaik80 <[email protected]> * update json file func changes Signed-off-by: shaik80 <[email protected]> * add version in json file Signed-off-by: shaik80 <[email protected]> * Pre and post checklist for embedded and external PG (#6705) * changes for pre post checklist Signed-off-by: Vivek Shankar <[email protected]> * minor changes Signed-off-by: Vivek Shankar <[email protected]> * changed formatting Signed-off-by: Vivek Shankar <[email protected]> * id changes Signed-off-by: Vivek Shankar <[email protected]> * Pg external Signed-off-by: shaik80 <[email protected]> * minor fmt changes Signed-off-by: Vivek Shankar <[email protected]> * spell check Signed-off-by: shaik80 <[email protected]> * variable change Signed-off-by: shaik80 <[email protected]> * remove log Signed-off-by: shaik80 <[email protected]> * postchecklist new structure Signed-off-by: shaik80 <[email protected]> * added new interface function for post checklist Signed-off-by: Vivek Yadav <[email protected]> * get post checklist implementation added Signed-off-by: Vivek Yadav <[email protected]> * feed back changes Signed-off-by: shaik80 <[email protected]> * code modification Signed-off-by: shaik80 <[email protected]> * if file not found return nil Signed-off-by: shaik80 <[email protected]> * if file not found don't throw an error Signed-off-by: shaik80 <[email protected]> * remove log and lint fix Signed-off-by: shaik80 <[email protected]> * NewChecklistManager remove major version param Signed-off-by: shaik80 <[email protected]> * Fixing pipeline issues Signed-off-by: shaik80 <[email protected]> * title for post checklist in upgrade status Signed-off-by: shaik80 <[email protected]> * making global constant Signed-off-by: shaik80 <[email protected]> Co-authored-by: vivekshankar1 <[email protected]> Co-authored-by: Vivek Shankar <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: dmaddu <[email protected]> * partial changes to fix pipeline Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * hiding versions-file flag to end users Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * removing the commented code Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * hiding the banner Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Fix automate UI pipeline issue (#6790) * pipline fix Signed-off-by: shaik80 <[email protected]> * automate pipline fix Signed-off-by: shaik80 <[email protected]> Co-authored-by: shaik80 <[email protected]> Co-authored-by: Kallol Roy <[email protected]> Co-authored-by: Rick Marry <[email protected]> Co-authored-by: Venkatesh-rengasamy <[email protected]> Co-authored-by: Shaik Mudassir <[email protected]> Co-authored-by: vivekshankar1 <[email protected]> Co-authored-by: Vivek Shankar <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: shivangisingh <[email protected]> Co-authored-by: shaik80 <[email protected]> * Executed '.expeditor/generate-automate-cli-docs.sh' Obvious fix; these changes are the result of automation not creative thinking. * regenerating the cert files (#6794) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Upgrade automate ha packages for 6.8.6 -> 6.8.23 (#6795) * upgrade es version to 6.8.23 in automate-ha * side car package bump to avaoid the confusion Signed-off-by: punitmundra <[email protected]> * License scout fix (#6798) * set git config global Signed-off-by: Vivek Yadav <[email protected]> * updated commit id of epgsql Signed-off-by: Vivek Yadav <[email protected]> * log git config updated in license scout Signed-off-by: Vivek Yadav <[email protected]> * changed url in git config override Signed-off-by: Vivek Yadav <[email protected]> * fix git:// in build and unit test of notification Signed-off-by: Vivek Yadav <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changed Service names to constants Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored code Signed-off-by: shanmugapriya-tr <[email protected]> * Changes to resolve the issue with service restart on patch Signed-off-by: sandhi <[email protected]> * Update components/automate-deployment/pkg/server/server.go Co-authored-by: Kallol Roy <[email protected]> * Changed array to map Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> Co-authored-by: shanmugapriya-tr <[email protected]> Co-authored-by: sandhi <[email protected]> Co-authored-by: Kallol Roy <[email protected]> Co-authored-by: Arvinth C <[email protected]> Co-authored-by: Deepa Kumaraswamy <[email protected]> Co-authored-by: Durga Sarat Chandra Maddu <[email protected]> Co-authored-by: Rick Marry <[email protected]> Co-authored-by: Venkatesh-rengasamy <[email protected]> Co-authored-by: Shaik Mudassir <[email protected]> Co-authored-by: vivekshankar1 <[email protected]> Co-authored-by: Vivek Shankar <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: shivangisingh <[email protected]> Co-authored-by: shaik80 <[email protected]> Co-authored-by: Chef Expeditor <[email protected]> Co-authored-by: punitmundra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ArvinthC3000 [email protected]
Description:
As an Automate HA user, the user needs to see a clean config.toml file with no unused/commented config keys in it. Unused config keys are removed from both the AWS and existing infra config templates. Also added a comment for users mentioning not to modify the value of the
backup_mountkey in the config file.⛓️ Related Resources
https://chefio.atlassian.net/browse/MADROX-80
👍 Definition of Done
It's dev done and tested
👟 How to Build and Test the Change
$ build components/automate-cli
$ hab pkg install -bf results/punitmundra-automate-cli-0.1.0-<PACKAGE_TIME_STAMP>-linux.hart
$ chef-automate init-config-ha [aws/existing_infra]
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable