showing pre post Checklist for milestone release #6706

shaik80 · 2022-02-17T10:05:08Z

🔩 Description: What code changed, and why?

This PR includes PrePost-checklist for the milestone release,
create JSON file after major version upgrade is done, and show post checklist in upgrade Status

⛓️ Related Resources

https://chefio.atlassian.net/browse/SHIELD-15?atlOrigin=eyJpIjoiZTIyMDliN2Y4ZDQxNDE4ZGFhOTIxMjE1MDQ4MWViNTUiLCJwIjoiaiJ9

👍 Definition of Done

Create JSON file for major version release when we run chef-automate upgrade run --major
Read JSON file after major version is upgraded when we run chef-automate upgrade status

👟 How to Build and Test the Change

automate git:(shaik/poc_pre_post_checklist) ✗  hab studio enter
[20][default:/src:0]# start_all_services 
[20][default:/src:0]# rebuild components/automate-deployment/
[20][default:/src:0]# rebuild components/automate-cli
[20][default:/src:0]# chef-automate upgrade run --major
[20][default:/src:0]# chef-automate upgrade status

✅ Checklist

All PRs must tick these:

I have read the CONTRIBUTING document.
All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

Tests added/updated? (all new code needs new tests)
Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

components/automate-deployment/pkg/majorupgradechecklist/checklist_manager.go

components/automate-cli/cmd/chef-automate/upgrade.go

components/automate-deployment/pkg/majorupgradechecklist/checklist_manager.go

components/automate-deployment/pkg/majorupgradechecklist/v3.go

components/automate-deployment/pkg/server/server.go

Dmaddu

looks good to me

components/automate-cli/cmd/chef-automate/upgrade.go

vivek-yadav · 2022-02-25T15:29:30Z

components/automate-deployment/pkg/majorupgradechecklist/v3.go

+	run_pg_data_cleanup = `If you are sure all data is available in Upgraded Automate, then we can free up old PostgreSQL 9.6 Data by running: 
+     $ ` + run_pg_data_cleanup_cmd
+
+	run_pg_data_cleanup_cmd        = `chef-automate post-major-upgrade clear-data --data=PG`


--data=PG are we sure this should be PG and not pg

will accept both pg and PG

Signed-off-by: shaik80 <[email protected]>

* changes for pre post checklist Signed-off-by: Vivek Shankar <[email protected]> * minor changes Signed-off-by: Vivek Shankar <[email protected]> * changed formatting Signed-off-by: Vivek Shankar <[email protected]> * id changes Signed-off-by: Vivek Shankar <[email protected]>

Signed-off-by: shaik80 <[email protected]>

Signed-off-by: Vivek Shankar <[email protected]>

Signed-off-by: shaik80 <[email protected]>

Signed-off-by: Vivek Yadav <[email protected]>

Signed-off-by: shaik80 <[email protected]>

sonarcloud · 2022-03-04T12:39:27Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

0.0% Coverage
0.0% Duplication

* postchecklist Signed-off-by: shaik80 <[email protected]> * json file Signed-off-by: shaik80 <[email protected]> * readPostCheckList Signed-off-by: shaik80 <[email protected]> * read json file for postchecklist Signed-off-by: shaik80 <[email protected]> * upgrade to major and and print postchecklist steps Signed-off-by: shaik80 <[email protected]> * test cases and basic changes Signed-off-by: shaik80 <[email protected]> * dynamic version Signed-off-by: shaik80 <[email protected]> * old manifests url Signed-off-by: shaik80 <[email protected]> * error handling in upgrade status if we don't hav compatible version Signed-off-by: shaik80 <[email protected]> * update json file func changes Signed-off-by: shaik80 <[email protected]> * add version in json file Signed-off-by: shaik80 <[email protected]> * Pre and post checklist for embedded and external PG (#6705) * changes for pre post checklist Signed-off-by: Vivek Shankar <[email protected]> * minor changes Signed-off-by: Vivek Shankar <[email protected]> * changed formatting Signed-off-by: Vivek Shankar <[email protected]> * id changes Signed-off-by: Vivek Shankar <[email protected]> * Pg external Signed-off-by: shaik80 <[email protected]> * minor fmt changes Signed-off-by: Vivek Shankar <[email protected]> * spell check Signed-off-by: shaik80 <[email protected]> * variable change Signed-off-by: shaik80 <[email protected]> * remove log Signed-off-by: shaik80 <[email protected]> * postchecklist new structure Signed-off-by: shaik80 <[email protected]> * added new interface function for post checklist Signed-off-by: Vivek Yadav <[email protected]> * get post checklist implementation added Signed-off-by: Vivek Yadav <[email protected]> * feed back changes Signed-off-by: shaik80 <[email protected]> * code modification Signed-off-by: shaik80 <[email protected]> * if file not found return nil Signed-off-by: shaik80 <[email protected]> * if file not found don't throw an error Signed-off-by: shaik80 <[email protected]> * remove log and lint fix Signed-off-by: shaik80 <[email protected]> * NewChecklistManager remove major version param Signed-off-by: shaik80 <[email protected]> * Fixing pipeline issues Signed-off-by: shaik80 <[email protected]> * title for post checklist in upgrade status Signed-off-by: shaik80 <[email protected]> * making global constant Signed-off-by: shaik80 <[email protected]> Co-authored-by: vivekshankar1 <[email protected]> Co-authored-by: Vivek Shankar <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: dmaddu <[email protected]>

* added Todo(milestone) for the servers Signed-off-by: Kallol Roy <[email protected]> * added more Todo(milestone) for the servers Signed-off-by: Kallol Roy <[email protected]> * adding to-dos Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * upgrading to minor/patch version (#6621) * upgrade to minor\patch Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * supporting sem version Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * considering version flag in upgrade Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * compute min current version for airgap bundle create- second pr (#6665) * adding min current version to manifest in bundle creation Signed-off-by: Rick Marry <[email protected]> * adding min current version to manifest in bundle creation Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> Co-authored-by: dmaddu <[email protected]> * major upgrade with checklist (#6660) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * fixing buildkite (#6674) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * airgap bundle upgrade (#6682) * airgap upgrade Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * upgrade status for airgap Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * upgrade status for airgap instance Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * addressing review comments Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Show Major Version Release Banner on UI (#6663) * banner-manual-upgrade changes Signed-off-by: Venkatesh-rengasamy <[email protected]> * add banner logo Signed-off-by: Venkatesh-rengasamy <[email protected]> * updating error messages to be shown to end user (#6714) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * ignoring semgrep rule Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * fixing pipeline issue (#6717) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * supporting external versions file (#6748) * supporting external versions file Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * fixing pipeline Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * showing pre post Checklist for milestone release (#6706) * postchecklist Signed-off-by: shaik80 <[email protected]> * json file Signed-off-by: shaik80 <[email protected]> * readPostCheckList Signed-off-by: shaik80 <[email protected]> * read json file for postchecklist Signed-off-by: shaik80 <[email protected]> * upgrade to major and and print postchecklist steps Signed-off-by: shaik80 <[email protected]> * test cases and basic changes Signed-off-by: shaik80 <[email protected]> * dynamic version Signed-off-by: shaik80 <[email protected]> * old manifests url Signed-off-by: shaik80 <[email protected]> * error handling in upgrade status if we don't hav compatible version Signed-off-by: shaik80 <[email protected]> * update json file func changes Signed-off-by: shaik80 <[email protected]> * add version in json file Signed-off-by: shaik80 <[email protected]> * Pre and post checklist for embedded and external PG (#6705) * changes for pre post checklist Signed-off-by: Vivek Shankar <[email protected]> * minor changes Signed-off-by: Vivek Shankar <[email protected]> * changed formatting Signed-off-by: Vivek Shankar <[email protected]> * id changes Signed-off-by: Vivek Shankar <[email protected]> * Pg external Signed-off-by: shaik80 <[email protected]> * minor fmt changes Signed-off-by: Vivek Shankar <[email protected]> * spell check Signed-off-by: shaik80 <[email protected]> * variable change Signed-off-by: shaik80 <[email protected]> * remove log Signed-off-by: shaik80 <[email protected]> * postchecklist new structure Signed-off-by: shaik80 <[email protected]> * added new interface function for post checklist Signed-off-by: Vivek Yadav <[email protected]> * get post checklist implementation added Signed-off-by: Vivek Yadav <[email protected]> * feed back changes Signed-off-by: shaik80 <[email protected]> * code modification Signed-off-by: shaik80 <[email protected]> * if file not found return nil Signed-off-by: shaik80 <[email protected]> * if file not found don't throw an error Signed-off-by: shaik80 <[email protected]> * remove log and lint fix Signed-off-by: shaik80 <[email protected]> * NewChecklistManager remove major version param Signed-off-by: shaik80 <[email protected]> * Fixing pipeline issues Signed-off-by: shaik80 <[email protected]> * title for post checklist in upgrade status Signed-off-by: shaik80 <[email protected]> * making global constant Signed-off-by: shaik80 <[email protected]> Co-authored-by: vivekshankar1 <[email protected]> Co-authored-by: Vivek Shankar <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: dmaddu <[email protected]> * partial changes to fix pipeline Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * hiding versions-file flag to end users Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * removing the commented code Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * hiding the banner Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Fix automate UI pipeline issue (#6790) * pipline fix Signed-off-by: shaik80 <[email protected]> * automate pipline fix Signed-off-by: shaik80 <[email protected]> Co-authored-by: shaik80 <[email protected]> Co-authored-by: Kallol Roy <[email protected]> Co-authored-by: Rick Marry <[email protected]> Co-authored-by: Venkatesh-rengasamy <[email protected]> Co-authored-by: Shaik Mudassir <[email protected]> Co-authored-by: vivekshankar1 <[email protected]> Co-authored-by: Vivek Shankar <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: shivangisingh <[email protected]> Co-authored-by: shaik80 <[email protected]>

* Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Added few debug logs Signed-off-by: shanmugapriya-tr <[email protected]> * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changed Service names to constants Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored code Signed-off-by: shanmugapriya-tr <[email protected]> * Changes to resolve the issue with service restart on patch Signed-off-by: sandhi <[email protected]> * Update components/automate-deployment/pkg/server/server.go Co-authored-by: Kallol Roy <[email protected]> * Changed array to map Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Changed Service names to constants Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored code Signed-off-by: shanmugapriya-tr <[email protected]> * Changes to resolve the issue with service restart on patch Signed-off-by: sandhi <[email protected]> * Update components/automate-deployment/pkg/server/server.go Co-authored-by: Kallol Roy <[email protected]> * Changed array to map Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changed Service names to constants Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored code Signed-off-by: shanmugapriya-tr <[email protected]> * Changes to resolve the issue with service restart on patch Signed-off-by: sandhi <[email protected]> * Update components/automate-deployment/pkg/server/server.go Co-authored-by: Kallol Roy <[email protected]> * Changed array to map Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * added automateHA mount path (#6739) * added automateHA mount path Signed-off-by: ArvinthC3000 <[email protected]> * added automateHA mount path - dynamic path test Signed-off-by: ArvinthC3000 <[email protected]> * Added backup_mount variable * backup_mount path from variables_common added(test commit) Signed-off-by: ArvinthC3000 <[email protected]> * reverting changes Signed-off-by: ArvinthC3000 <[email protected]> * Adding dynamic mount path to automate backup folder creation Signed-off-by: ArvinthC3000 <[email protected]> * Static backup mount path * trigger changes Signed-off-by: ArvinthC3000 <[email protected]> * removing dead code Signed-off-by: ArvinthC3000 <[email protected]> * Rename HA_architecture_reference.md to ha_architecture_reference.md * removed unused config keys (#6781) Signed-off-by: ArvinthC3000 <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changed Service names to constants Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored code Signed-off-by: shanmugapriya-tr <[email protected]> * Changes to resolve the issue with service restart on patch Signed-off-by: sandhi <[email protected]> * Update components/automate-deployment/pkg/server/server.go Co-authored-by: Kallol Roy <[email protected]> * Changed array to map Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Fixing License Scout (#6782) * Fixing License Scout Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Fixing License Scout for msgp Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Cli milestone part-1 (#6762) * added Todo(milestone) for the servers Signed-off-by: Kallol Roy <[email protected]> * added more Todo(milestone) for the servers Signed-off-by: Kallol Roy <[email protected]> * adding to-dos Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * upgrading to minor/patch version (#6621) * upgrade to minor\patch Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * supporting sem version Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * considering version flag in upgrade Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * compute min current version for airgap bundle create- second pr (#6665) * adding min current version to manifest in bundle creation Signed-off-by: Rick Marry <[email protected]> * adding min current version to manifest in bundle creation Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> Co-authored-by: dmaddu <[email protected]> * major upgrade with checklist (#6660) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * fixing buildkite (#6674) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * airgap bundle upgrade (#6682) * airgap upgrade Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * upgrade status for airgap Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * upgrade status for airgap instance Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * addressing review comments Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Show Major Version Release Banner on UI (#6663) * banner-manual-upgrade changes Signed-off-by: Venkatesh-rengasamy <[email protected]> * add banner logo Signed-off-by: Venkatesh-rengasamy <[email protected]> * updating error messages to be shown to end user (#6714) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * ignoring semgrep rule Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * fixing pipeline issue (#6717) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * supporting external versions file (#6748) * supporting external versions file Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * fixing pipeline Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * showing pre post Checklist for milestone release (#6706) * postchecklist Signed-off-by: shaik80 <[email protected]> * json file Signed-off-by: shaik80 <[email protected]> * readPostCheckList Signed-off-by: shaik80 <[email protected]> * read json file for postchecklist Signed-off-by: shaik80 <[email protected]> * upgrade to major and and print postchecklist steps Signed-off-by: shaik80 <[email protected]> * test cases and basic changes Signed-off-by: shaik80 <[email protected]> * dynamic version Signed-off-by: shaik80 <[email protected]> * old manifests url Signed-off-by: shaik80 <[email protected]> * error handling in upgrade status if we don't hav compatible version Signed-off-by: shaik80 <[email protected]> * update json file func changes Signed-off-by: shaik80 <[email protected]> * add version in json file Signed-off-by: shaik80 <[email protected]> * Pre and post checklist for embedded and external PG (#6705) * changes for pre post checklist Signed-off-by: Vivek Shankar <[email protected]> * minor changes Signed-off-by: Vivek Shankar <[email protected]> * changed formatting Signed-off-by: Vivek Shankar <[email protected]> * id changes Signed-off-by: Vivek Shankar <[email protected]> * Pg external Signed-off-by: shaik80 <[email protected]> * minor fmt changes Signed-off-by: Vivek Shankar <[email protected]> * spell check Signed-off-by: shaik80 <[email protected]> * variable change Signed-off-by: shaik80 <[email protected]> * remove log Signed-off-by: shaik80 <[email protected]> * postchecklist new structure Signed-off-by: shaik80 <[email protected]> * added new interface function for post checklist Signed-off-by: Vivek Yadav <[email protected]> * get post checklist implementation added Signed-off-by: Vivek Yadav <[email protected]> * feed back changes Signed-off-by: shaik80 <[email protected]> * code modification Signed-off-by: shaik80 <[email protected]> * if file not found return nil Signed-off-by: shaik80 <[email protected]> * if file not found don't throw an error Signed-off-by: shaik80 <[email protected]> * remove log and lint fix Signed-off-by: shaik80 <[email protected]> * NewChecklistManager remove major version param Signed-off-by: shaik80 <[email protected]> * Fixing pipeline issues Signed-off-by: shaik80 <[email protected]> * title for post checklist in upgrade status Signed-off-by: shaik80 <[email protected]> * making global constant Signed-off-by: shaik80 <[email protected]> Co-authored-by: vivekshankar1 <[email protected]> Co-authored-by: Vivek Shankar <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: dmaddu <[email protected]> * partial changes to fix pipeline Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * hiding versions-file flag to end users Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * removing the commented code Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * hiding the banner Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Fix automate UI pipeline issue (#6790) * pipline fix Signed-off-by: shaik80 <[email protected]> * automate pipline fix Signed-off-by: shaik80 <[email protected]> Co-authored-by: shaik80 <[email protected]> Co-authored-by: Kallol Roy <[email protected]> Co-authored-by: Rick Marry <[email protected]> Co-authored-by: Venkatesh-rengasamy <[email protected]> Co-authored-by: Shaik Mudassir <[email protected]> Co-authored-by: vivekshankar1 <[email protected]> Co-authored-by: Vivek Shankar <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: shivangisingh <[email protected]> Co-authored-by: shaik80 <[email protected]> * Executed '.expeditor/generate-automate-cli-docs.sh' Obvious fix; these changes are the result of automation not creative thinking. * regenerating the cert files (#6794) Signed-off-by: Durga Sarat Chandra Maddu <[email protected]> * Upgrade automate ha packages for 6.8.6 -> 6.8.23 (#6795) * upgrade es version to 6.8.23 in automate-ha * side car package bump to avaoid the confusion Signed-off-by: punitmundra <[email protected]> * License scout fix (#6798) * set git config global Signed-off-by: Vivek Yadav <[email protected]> * updated commit id of epgsql Signed-off-by: Vivek Yadav <[email protected]> * log git config updated in license scout Signed-off-by: Vivek Yadav <[email protected]> * changed url in git config override Signed-off-by: Vivek Yadav <[email protected]> * fix git:// in build and unit test of notification Signed-off-by: Vivek Yadav <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored skipping services health check Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External ES 1. Added the code to skip the automate-elasticsearch service if External is enabled 2. Decoupled the es-sidecar service from automate-elasticsearch 3. Moved the code to skip the status check for removed services in ensureStatus Signed-off-by: sandhi <[email protected]> * Added few debug logs * Making binds optional Signed-off-by: shanmugapriya-tr <[email protected]> * Changed Service names to constants Signed-off-by: shanmugapriya-tr <[email protected]> * Refactored code Signed-off-by: shanmugapriya-tr <[email protected]> * Changes to resolve the issue with service restart on patch Signed-off-by: sandhi <[email protected]> * Update components/automate-deployment/pkg/server/server.go Co-authored-by: Kallol Roy <[email protected]> * Changed array to map Signed-off-by: shanmugapriya-tr <[email protected]> * Changes for External PG Signed-off-by: shanmugapriya-tr <[email protected]> Co-authored-by: shanmugapriya-tr <[email protected]> Co-authored-by: sandhi <[email protected]> Co-authored-by: Kallol Roy <[email protected]> Co-authored-by: Arvinth C <[email protected]> Co-authored-by: Deepa Kumaraswamy <[email protected]> Co-authored-by: Durga Sarat Chandra Maddu <[email protected]> Co-authored-by: Rick Marry <[email protected]> Co-authored-by: Venkatesh-rengasamy <[email protected]> Co-authored-by: Shaik Mudassir <[email protected]> Co-authored-by: vivekshankar1 <[email protected]> Co-authored-by: Vivek Shankar <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: shivangisingh <[email protected]> Co-authored-by: shaik80 <[email protected]> Co-authored-by: Chef Expeditor <[email protected]> Co-authored-by: punitmundra <[email protected]>

Dmaddu force-pushed the cli_milestone_ready branch from ffdcca0 to 2c4bc60 Compare February 18, 2022 07:07

shaik80 force-pushed the shaik/poc_pre_post_checklist branch from 3595932 to 7bb62ff Compare February 18, 2022 13:57

Dmaddu force-pushed the cli_milestone_ready branch from f0888f7 to fc60a53 Compare February 21, 2022 07:01

shaik80 force-pushed the shaik/poc_pre_post_checklist branch from 7bb62ff to c5d01d2 Compare February 21, 2022 13:22

shaik80 requested review from Dmaddu, vivek-yadav, vivekshankar1 and a team February 21, 2022 13:23

vivekshankar1 approved these changes Feb 22, 2022

View reviewed changes

shaik80 requested review from rickmarry and punitmundra February 22, 2022 12:47

vivekshankar1 requested changes Feb 22, 2022

View reviewed changes

components/automate-deployment/pkg/majorupgradechecklist/checklist_manager.go Outdated Show resolved Hide resolved

components/automate-deployment/pkg/majorupgradechecklist/checklist_manager.go Outdated Show resolved Hide resolved

Dmaddu requested changes Feb 23, 2022

View reviewed changes

Dmaddu force-pushed the cli_milestone_ready branch from fc60a53 to 4be7170 Compare February 23, 2022 05:14

shaik80 force-pushed the shaik/poc_pre_post_checklist branch from f1ac9b8 to ce86717 Compare February 23, 2022 10:00

Dmaddu approved these changes Feb 23, 2022

View reviewed changes

vivek-yadav reviewed Feb 25, 2022

View reviewed changes

components/automate-cli/cmd/chef-automate/upgrade.go Outdated Show resolved Hide resolved

vivek-yadav reviewed Feb 25, 2022

View reviewed changes

components/automate-cli/cmd/chef-automate/upgrade.go Outdated Show resolved Hide resolved

vivek-yadav reviewed Feb 25, 2022

View reviewed changes

components/automate-cli/cmd/chef-automate/upgrade.go Outdated Show resolved Hide resolved

vivek-yadav reviewed Feb 25, 2022

View reviewed changes

Dmaddu force-pushed the cli_milestone_ready branch from 4be7170 to 9362c63 Compare February 28, 2022 09:12

shaik80 force-pushed the shaik/poc_pre_post_checklist branch from f453c7e to d9c6d39 Compare February 28, 2022 12:10

Dmaddu force-pushed the cli_milestone_ready branch 3 times, most recently from c6f7626 to 1105745 Compare March 3, 2022 06:55

shaik80 force-pushed the shaik/poc_pre_post_checklist branch from 9b90d9d to f983b99 Compare March 3, 2022 07:00

Dmaddu force-pushed the cli_milestone_ready branch from b90d98c to 7bdbe15 Compare March 4, 2022 11:05

shaik80 added 3 commits March 4, 2022 16:36

postchecklist

adeaa76

Signed-off-by: shaik80 <[email protected]>

json file

a6646af

Signed-off-by: shaik80 <[email protected]>

readPostCheckList

41f9c2e

Signed-off-by: shaik80 <[email protected]>

shaik80 and others added 17 commits March 4, 2022 16:36

update json file func changes

284c928

Signed-off-by: shaik80 <[email protected]>

add version in json file

7dc4357

Signed-off-by: shaik80 <[email protected]>

Pg external

df89f64

Signed-off-by: shaik80 <[email protected]>

minor fmt changes

c16633e

Signed-off-by: Vivek Shankar <[email protected]>

spell check

6d846e2

Signed-off-by: shaik80 <[email protected]>

variable change

3bf4e6b

Signed-off-by: shaik80 <[email protected]>

remove log

054e930

Signed-off-by: shaik80 <[email protected]>

postchecklist new structure

54a3e66

Signed-off-by: shaik80 <[email protected]>

added new interface function for post checklist

7d25df7

Signed-off-by: Vivek Yadav <[email protected]>

get post checklist implementation added

545d5b7

Signed-off-by: Vivek Yadav <[email protected]>

feed back changes

11213e0

Signed-off-by: shaik80 <[email protected]>

code modification

0e252ba

Signed-off-by: shaik80 <[email protected]>

if file not found return nil

552cff2

Signed-off-by: shaik80 <[email protected]>

if file not found don't throw an error

ac39dfe

Signed-off-by: shaik80 <[email protected]>

remove log and lint fix

b87f043

Signed-off-by: shaik80 <[email protected]>

NewChecklistManager remove major version param

8d54558

Signed-off-by: shaik80 <[email protected]>

Dmaddu force-pushed the shaik/poc_pre_post_checklist branch from 04e2ed8 to 8d54558 Compare March 4, 2022 11:06

Dmaddu and others added 3 commits March 4, 2022 16:43

Fixing pipeline issues

7bca3d9

Signed-off-by: shaik80 <[email protected]>

title for post checklist in upgrade status

ae6cf7b

Signed-off-by: shaik80 <[email protected]>

making global constant

590aa00

Signed-off-by: shaik80 <[email protected]>

Dmaddu merged commit f540136 into cli_milestone_ready Mar 4, 2022

Dmaddu deleted the shaik/poc_pre_post_checklist branch March 4, 2022 13:14

Dmaddu restored the shaik/poc_pre_post_checklist branch March 4, 2022 13:58

kalroy added the acceptance: internal label Mar 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

showing pre post Checklist for milestone release #6706

showing pre post Checklist for milestone release #6706

shaik80 commented Feb 17, 2022 •

edited

Loading

Dmaddu left a comment

vivek-yadav Feb 25, 2022

shaik80 Feb 28, 2022

sonarcloud bot commented Mar 4, 2022

showing pre post Checklist for milestone release #6706

showing pre post Checklist for milestone release #6706

Conversation

shaik80 commented Feb 17, 2022 • edited Loading

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

📷 Screenshots, if applicable

Dmaddu left a comment

Choose a reason for hiding this comment

vivek-yadav Feb 25, 2022

Choose a reason for hiding this comment

shaik80 Feb 28, 2022

Choose a reason for hiding this comment

sonarcloud bot commented Mar 4, 2022

shaik80 commented Feb 17, 2022 •

edited

Loading