Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing License Scout #6782

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Fixing License Scout #6782

merged 2 commits into from
Mar 10, 2022

Conversation

Dmaddu
Copy link
Collaborator

@Dmaddu Dmaddu commented Mar 9, 2022

Signed-off-by: Durga Sarat Chandra Maddu [email protected]
Issue: https://chefio.atlassian.net/browse/KINETICS-58

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>
@netlify
Copy link

netlify bot commented Mar 9, 2022

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: b8de79d

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6229a702b471c900089eec5d

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Dmaddu Dmaddu requested a review from kalroy March 10, 2022 07:34
@Dmaddu Dmaddu marked this pull request as ready for review March 10, 2022 09:59
@Dmaddu
Copy link
Collaborator Author

Dmaddu commented Mar 10, 2022

As per tinylib/msgp#287
the license resembles MIT license and since the other repositories in tinylib are having MIT licenses, considering the msgp license also as MIT

@kalroy kalroy merged commit f4b4aa2 into main Mar 10, 2022
@kalroy kalroy deleted the fix_license_scout branch March 10, 2022 10:05
kalroy added a commit that referenced this pull request Mar 18, 2022
* Changes for External PG

Signed-off-by: shanmugapriya-tr <[email protected]>

* Refactored skipping services health check

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External ES
1. Added the code to skip the automate-elasticsearch service if External is enabled
2. Decoupled the es-sidecar service from automate-elasticsearch
3. Moved the code to skip the status check for removed services in ensureStatus

Signed-off-by: sandhi <[email protected]>

* Added few debug logs

* Added few debug logs

Signed-off-by: shanmugapriya-tr <[email protected]>

* Making binds optional

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External PG

Signed-off-by: shanmugapriya-tr <[email protected]>

* Refactored skipping services health check

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External ES
1. Added the code to skip the automate-elasticsearch service if External is enabled
2. Decoupled the es-sidecar service from automate-elasticsearch
3. Moved the code to skip the status check for removed services in ensureStatus

Signed-off-by: sandhi <[email protected]>

* Added few debug logs

* Making binds optional

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changed Service names to constants

Signed-off-by: shanmugapriya-tr <[email protected]>

* Refactored code

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes to resolve the issue with service restart on patch

Signed-off-by: sandhi <[email protected]>

* Update components/automate-deployment/pkg/server/server.go

Co-authored-by: Kallol Roy <[email protected]>

* Changed array to map

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External PG

Signed-off-by: shanmugapriya-tr <[email protected]>

* Refactored skipping services health check

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External ES
1. Added the code to skip the automate-elasticsearch service if External is enabled
2. Decoupled the es-sidecar service from automate-elasticsearch
3. Moved the code to skip the status check for removed services in ensureStatus

Signed-off-by: sandhi <[email protected]>

* Added few debug logs

* Making binds optional

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External PG

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changed Service names to constants

Signed-off-by: shanmugapriya-tr <[email protected]>

* Refactored code

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes to resolve the issue with service restart on patch

Signed-off-by: sandhi <[email protected]>

* Update components/automate-deployment/pkg/server/server.go

Co-authored-by: Kallol Roy <[email protected]>

* Changed array to map

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External PG

Signed-off-by: shanmugapriya-tr <[email protected]>

* Refactored skipping services health check

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External ES
1. Added the code to skip the automate-elasticsearch service if External is enabled
2. Decoupled the es-sidecar service from automate-elasticsearch
3. Moved the code to skip the status check for removed services in ensureStatus

Signed-off-by: sandhi <[email protected]>

* Added few debug logs

* Making binds optional

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changed Service names to constants

Signed-off-by: shanmugapriya-tr <[email protected]>

* Refactored code

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes to resolve the issue with service restart on patch

Signed-off-by: sandhi <[email protected]>

* Update components/automate-deployment/pkg/server/server.go

Co-authored-by: Kallol Roy <[email protected]>

* Changed array to map

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External PG

Signed-off-by: shanmugapriya-tr <[email protected]>

* added automateHA mount path (#6739)

* added automateHA mount path

Signed-off-by: ArvinthC3000 <[email protected]>

* added automateHA mount path - dynamic path test

Signed-off-by: ArvinthC3000 <[email protected]>

* Added backup_mount variable

* backup_mount path from variables_common added(test commit)

Signed-off-by: ArvinthC3000 <[email protected]>

* reverting changes

Signed-off-by: ArvinthC3000 <[email protected]>

* Adding dynamic mount path to automate backup folder creation

Signed-off-by: ArvinthC3000 <[email protected]>

* Static backup mount path

* trigger changes

Signed-off-by: ArvinthC3000 <[email protected]>

* removing dead code

Signed-off-by: ArvinthC3000 <[email protected]>

* Rename HA_architecture_reference.md to ha_architecture_reference.md

* removed unused config keys (#6781)

Signed-off-by: ArvinthC3000 <[email protected]>

* Changes for External PG

Signed-off-by: shanmugapriya-tr <[email protected]>

* Refactored skipping services health check

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External ES
1. Added the code to skip the automate-elasticsearch service if External is enabled
2. Decoupled the es-sidecar service from automate-elasticsearch
3. Moved the code to skip the status check for removed services in ensureStatus

Signed-off-by: sandhi <[email protected]>

* Added few debug logs

* Making binds optional

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changed Service names to constants

Signed-off-by: shanmugapriya-tr <[email protected]>

* Refactored code

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes to resolve the issue with service restart on patch

Signed-off-by: sandhi <[email protected]>

* Update components/automate-deployment/pkg/server/server.go

Co-authored-by: Kallol Roy <[email protected]>

* Changed array to map

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External PG

Signed-off-by: shanmugapriya-tr <[email protected]>

* Fixing License Scout (#6782)

* Fixing License Scout

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* Fixing License Scout for msgp

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* Cli milestone part-1 (#6762)

* added Todo(milestone) for the servers

Signed-off-by: Kallol Roy <[email protected]>

* added more Todo(milestone) for the servers

Signed-off-by: Kallol Roy <[email protected]>

* adding to-dos

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* upgrading to minor/patch version (#6621)

* upgrade to minor\patch

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* supporting sem version

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* considering version flag in upgrade

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* compute min current version for airgap bundle create- second pr (#6665)

* adding min current version to manifest in bundle creation

Signed-off-by: Rick Marry <[email protected]>

* adding min current version to manifest in bundle creation

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

Co-authored-by: dmaddu <[email protected]>

* major upgrade with checklist (#6660)

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* fixing buildkite (#6674)

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* airgap bundle upgrade (#6682)

* airgap upgrade

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* upgrade status for airgap

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* upgrade status for airgap instance

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* addressing review comments

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* Show Major Version Release Banner on UI (#6663)

* banner-manual-upgrade changes

Signed-off-by: Venkatesh-rengasamy <[email protected]>

* add banner logo

Signed-off-by: Venkatesh-rengasamy <[email protected]>

* updating error messages to be shown to end user (#6714)

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* ignoring semgrep rule

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* fixing pipeline issue (#6717)

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* supporting external versions file (#6748)

* supporting external versions file

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* fixing pipeline

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* showing pre post Checklist for milestone release  (#6706)

* postchecklist

Signed-off-by: shaik80 <[email protected]>

* json file

Signed-off-by: shaik80 <[email protected]>

* readPostCheckList

Signed-off-by: shaik80 <[email protected]>

* read json file for postchecklist

Signed-off-by: shaik80 <[email protected]>

* upgrade to major and and print postchecklist steps

Signed-off-by: shaik80 <[email protected]>

* test cases and basic changes

Signed-off-by: shaik80 <[email protected]>

* dynamic version

Signed-off-by: shaik80 <[email protected]>

* old manifests url

Signed-off-by: shaik80 <[email protected]>

* error handling in upgrade status if we don't hav compatible version

Signed-off-by: shaik80 <[email protected]>

* update json file func changes

Signed-off-by: shaik80 <[email protected]>

* add version in json file

Signed-off-by: shaik80 <[email protected]>

* Pre and post checklist for embedded and external PG (#6705)

* changes for pre post checklist

Signed-off-by: Vivek Shankar <[email protected]>

* minor changes

Signed-off-by: Vivek Shankar <[email protected]>

* changed formatting

Signed-off-by: Vivek Shankar <[email protected]>

* id changes

Signed-off-by: Vivek Shankar <[email protected]>

* Pg external

Signed-off-by: shaik80 <[email protected]>

* minor fmt changes

Signed-off-by: Vivek Shankar <[email protected]>

* spell check

Signed-off-by: shaik80 <[email protected]>

* variable change

Signed-off-by: shaik80 <[email protected]>

* remove log

Signed-off-by: shaik80 <[email protected]>

* postchecklist new structure

Signed-off-by: shaik80 <[email protected]>

* added new interface function for post checklist

Signed-off-by: Vivek Yadav <[email protected]>

* get post checklist implementation added

Signed-off-by: Vivek Yadav <[email protected]>

* feed back changes

Signed-off-by: shaik80 <[email protected]>

* code modification

Signed-off-by: shaik80 <[email protected]>

* if file not found return nil

Signed-off-by: shaik80 <[email protected]>

* if file not found don't throw an error

Signed-off-by: shaik80 <[email protected]>

* remove log and lint fix

Signed-off-by: shaik80 <[email protected]>

* NewChecklistManager remove major version param

Signed-off-by: shaik80 <[email protected]>

* Fixing pipeline issues

Signed-off-by: shaik80 <[email protected]>

* title for post checklist in upgrade status

Signed-off-by: shaik80 <[email protected]>

* making global constant

Signed-off-by: shaik80 <[email protected]>

Co-authored-by: vivekshankar1 <[email protected]>
Co-authored-by: Vivek Shankar <[email protected]>
Co-authored-by: Vivek Yadav <[email protected]>
Co-authored-by: dmaddu <[email protected]>

* partial changes to fix pipeline

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* hiding versions-file flag to end users

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* removing the commented code

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* hiding the banner

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* Fix automate UI pipeline issue (#6790)

* pipline fix

Signed-off-by: shaik80 <[email protected]>

* automate pipline fix

Signed-off-by: shaik80 <[email protected]>

Co-authored-by: shaik80 <[email protected]>

Co-authored-by: Kallol Roy <[email protected]>
Co-authored-by: Rick Marry <[email protected]>
Co-authored-by: Venkatesh-rengasamy <[email protected]>
Co-authored-by: Shaik Mudassir <[email protected]>
Co-authored-by: vivekshankar1 <[email protected]>
Co-authored-by: Vivek Shankar <[email protected]>
Co-authored-by: Vivek Yadav <[email protected]>
Co-authored-by: shivangisingh <[email protected]>
Co-authored-by: shaik80 <[email protected]>

* Executed '.expeditor/generate-automate-cli-docs.sh'

Obvious fix; these changes are the result of automation not creative thinking.

* regenerating the cert files (#6794)

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* Upgrade automate ha packages for 6.8.6 -> 6.8.23 (#6795)

* upgrade es version to 6.8.23 in automate-ha

* side car package bump to avaoid the confusion

Signed-off-by: punitmundra <[email protected]>

* License scout fix (#6798)

* set git config global

Signed-off-by: Vivek Yadav <[email protected]>

* updated commit id of epgsql

Signed-off-by: Vivek Yadav <[email protected]>

* log git config updated in license scout

Signed-off-by: Vivek Yadav <[email protected]>

* changed url in git config override

Signed-off-by: Vivek Yadav <[email protected]>

* fix git:// in build and unit test of notification

Signed-off-by: Vivek Yadav <[email protected]>

* Changes for External PG

Signed-off-by: shanmugapriya-tr <[email protected]>

* Refactored skipping services health check

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External ES
1. Added the code to skip the automate-elasticsearch service if External is enabled
2. Decoupled the es-sidecar service from automate-elasticsearch
3. Moved the code to skip the status check for removed services in ensureStatus

Signed-off-by: sandhi <[email protected]>

* Added few debug logs

* Making binds optional

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changed Service names to constants

Signed-off-by: shanmugapriya-tr <[email protected]>

* Refactored code

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes to resolve the issue with service restart on patch

Signed-off-by: sandhi <[email protected]>

* Update components/automate-deployment/pkg/server/server.go

Co-authored-by: Kallol Roy <[email protected]>

* Changed array to map

Signed-off-by: shanmugapriya-tr <[email protected]>

* Changes for External PG

Signed-off-by: shanmugapriya-tr <[email protected]>

Co-authored-by: shanmugapriya-tr <[email protected]>
Co-authored-by: sandhi <[email protected]>
Co-authored-by: Kallol Roy <[email protected]>
Co-authored-by: Arvinth C <[email protected]>
Co-authored-by: Deepa Kumaraswamy <[email protected]>
Co-authored-by: Durga Sarat Chandra Maddu <[email protected]>
Co-authored-by: Rick Marry <[email protected]>
Co-authored-by: Venkatesh-rengasamy <[email protected]>
Co-authored-by: Shaik Mudassir <[email protected]>
Co-authored-by: vivekshankar1 <[email protected]>
Co-authored-by: Vivek Shankar <[email protected]>
Co-authored-by: Vivek Yadav <[email protected]>
Co-authored-by: shivangisingh <[email protected]>
Co-authored-by: shaik80 <[email protected]>
Co-authored-by: Chef Expeditor <[email protected]>
Co-authored-by: punitmundra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants