Fix indexScale pan/zoom proportion #151 #152
Conversation
Plus stop zooming on indexScale when panning.
|
Is this plugin officially abandonware? |
|
@subogero sorry for the long delay in reviewing. This PR will need to be rebased against master |
| newMin = scale.getValueForPixel(scale.getPixelForValue(start) - delta); | ||
| newMax = scale.getValueForPixel(scale.getPixelForValue(end) - delta); | ||
|
|
||
| // Dont scale if either limit is reached |
|
|
||
| zoomNS.panCumulativeDelta += delta; | ||
| var dIndex = scale.getValueForPixel(Math.abs(delta)) - scale.getValueForPixel(0); |
There was a problem hiding this comment.
Is dIndex short for deltaIndex? If so, I'd prefer that as a variable name to be a bit clearer
| if (tickOpts.reverse) { | ||
| tickOpts.max = scale.getValueForPixel(scale.getPixelForValue(start) - delta); | ||
| tickOpts.min = scale.getValueForPixel(scale.getPixelForValue(end) - delta); | ||
| var rangeMin, rangeMax |
There was a problem hiding this comment.
It looks like maybe we can replace the logic from here down with a call to rangeMinLimiter and rangeMaxLimiter?
|
@subogero thanks for this PR. And sorry again for the delay in reviewing. I'm trying to get all the pending PRs merged. I know it's been awhile. If you could let me know if you're still interested in this PR or not that would be helpful, so that I know whether to wait to cut a release to include this one. Thanks again |
|
@subogero just checking in on this to see if you're still interested in pursuing. Sorry again for the long wait |
|
@subogero just a reminder that this PR will need to be rebased. Are you still interested in getting it in? |
|
Needs a rebase. The proportion part was already merged, but the stop zooming part would still be valid fix. |
|
Closing as everything in this has already been implemented |
Plus stop zooming on indexScale when panning.