Zoom using zoomPercent #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #379
So, when using e.g. 1000 data-points, the zoom is slow in ticks of 1. It seems the indices were only changed in ticks of 1, rather than ticks of the percentage of the current-range.
This PR uses the speed property to set the percentage of the current range to be zoomed, e.g. with 1000 data points currently in view, a speed of 0.1 means we zoom 10% in on that range.
Next up should be to zoom at centerPointer, rather than either right or left.
EDIT: Not sure if this overlaps with #152, but please do some update on that in that case.