Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix category scale Zoom/Pan proportion problems #151

Closed
subogero opened this issue May 31, 2018 · 4 comments · Fixed by #476
Closed

Fix category scale Zoom/Pan proportion problems #151

subogero opened this issue May 31, 2018 · 4 comments · Fixed by #476
Labels
bug

Comments

@subogero
Copy link

Plus panning on indexScale when zoomed in also causes zoom.

Zoom: the zoom parameter is a proportion. On linearScale it does work like that, but on the indexScale it's adding/removing 1 label at a time. Totally broken with large datasets. Make it work like linearScale.

Pan: calculate dIndex first, limit if 0 .. lastLabelIndex range would be exceeded, then modify minIndex, maxIndex with the exact same dIndex.

Pan on indexScale currently unusable with large datasets. Make pan distance proportional to mouse/touch gesture size.

Probably fixes some other related issues.

Pull request coming immediately.
subogero added a commit to subogero/chartjs-plugin-zoom that referenced this issue May 31, 2018
@subogero
Fix indexScale pan/zoom proportion chartjs#151
eb99d26 
Plus stop zooming on indexScale when panning.
@subogero
Copy link
Author

subogero commented Jun 1, 2018

Also see https://www.reddit.com/r/webdev/comments/8nqcq0/best_js_lib_for_charts/

@benmccann benmccann mentioned this issue Jan 24, 2019
Merged
@benmccann
Copy link
Collaborator

Also reported in #190

@benmccann
Copy link
Collaborator

Pending PR: #152

@etimberg etimberg mentioned this issue Apr 25, 2021
Closed
@etimberg etimberg added the bug label Apr 25, 2021
@etimberg etimberg changed the title Fix indexScale Zoom/Pan proportion problems Fix category scale Zoom/Pan proportion problems Apr 25, 2021
@kurkle kurkle linked a pull request May 1, 2021 that will close this issue
Fix category panning #476
Merged
@kurkle
Copy link
Member

kurkle commented May 1, 2021

I believe this was fixed in #476

@kurkle kurkle closed this as completed May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix category panning kurkle/chartjs-plugin-zoom
4 participants
@benmccann @subogero @etimberg @kurkle