Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventLoop sequenceMsg should check cmd is not nil #639

Closed
nderjung opened this issue Jan 20, 2023 · 1 comment · Fixed by #640
Closed

eventLoop sequenceMsg should check cmd is not nil #639

nderjung opened this issue Jan 20, 2023 · 1 comment · Fixed by #640

Comments

@nderjung
Copy link
Contributor

Supplying a cmd which is nil (which may be mixed in a sequence of cmds) will result in a nil pointer exception when the eventLoop iterates over the list of msg.

This issue tracks a simple if cmd != nil to be added before invoking cmd().
@nderjung nderjung mentioned this issue Jan 20, 2023
Merged
nderjung added a commit to nderjung/bubbletea that referenced this issue Jan 20, 2023
@nderjung
fix: Check msg cmd is not nil before invoking
11702a8 
GitHub-Fixes: charmbracelet#639
Signed-off-by: Alexander Jung <[email protected]>
@nderjung nderjung mentioned this issue Jan 20, 2023
Merged
@meowgorithm
Copy link
Member

Thanks so much for catching this one! Merging your PR shortly.

meowgorithm pushed a commit that referenced this issue Jan 23, 2023
@nderjung @meowgorithm
fix: Check msg cmd is not nil before invoking
b217449 
GitHub-Fixes: #639
Signed-off-by: Alexander Jung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Check msg cmd is not nil before invoking nderjung/bubbletea
2 participants
@meowgorithm @nderjung