Fix added bugs and inconsistencies #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cezar Craciunoiu <[email protected]>
Signed-off-by: Cezar Craciunoiu <[email protected]>
craciunoiuc
force-pushed
the
craciunoiuc/fix-added-bugs
branch
2 times, most recently
from
cfdd167 to
427be41
Compare
nderjung
requested changes
Jan 20, 2023
tui/paraprogress/paraprogress.go
Outdated
Comment on lines
171
to
174
| // This line will disable linting for the whole file, be careful | ||
| //nolint:staticcheck | ||
| //lint:ignore SA1019 using Sequence is currently breaking inside bubbletea | ||
| return md, tea.Sequentially(tea.Batch(cmds...), tea.Quit) |
There was a problem hiding this comment.
This issue arises from upgrading bubbletea which exposes a new API. Since using this API throws a nil pointer exception and instead of ignoring the underlying issue and using the older now deprecated API by ignoring all issues in the file a separate issue in itself, we should address the nil pointer directly. Taking a look at how the new API from bubbletea works shows that the nil will be returned by tea.Batch if the list of cmds is empty. So we can check for this return type and simply tea.Quit if this is the case:
batch := tea.Batch(cmds...)
if batch == nil {
return md, tea.Quit
}
return md, tea.Sequence(batch, tea.Quit)Please adapt the above explanation text in the git commit message which fixes this issue.
There was a problem hiding this comment.
This fixes a crash for all commands caused by bfaa6e0. The crash happens inside a dependency and is caused by the the combination of `Batch` and `Sequence` functions. `Batch` can now return `nil` which needs to be handled. Signed-off-by: Cezar Craciunoiu <[email protected]>
craciunoiuc
force-pushed
the
craciunoiuc/fix-added-bugs
branch
from
427be41 to
222af7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two commits remove a wrongly added binary and then ignore tool binaries from now on.
The last reverts a function from bubbletea that currently breaks when running in kraftkit.