Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check msg cmd is not nil before invoking #640

Merged
merged 1 commit into from
Jan 23, 2023
Merged

fix: Check msg cmd is not nil before invoking #640

merged 1 commit into from
Jan 23, 2023

Conversation

nderjung
Copy link
Contributor

GitHub-Fixes: #639

@meowgorithm
Copy link
Member

Good catch—this makes sense to me. @muesli, look good to you?

@muesli
Copy link
Contributor

muesli commented Jan 23, 2023

Looks good to me, too. We do a similar check for batched messages.

@meowgorithm meowgorithm merged commit b217449 into charmbracelet:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eventLoop sequenceMsg should check cmd is not nil
3 participants
@nderjung @meowgorithm @muesli